Update json-c to 0.13.1
ClosedPublic
Actions

Authored by JamesLee on Oct 27 2018, 4:09 PM.

Details

Reviewers

joebonrichie

Group Reviewers

Triage Team

Commits

R1507:cd9a7b8befdc: Update json-c to 0.13.1

Summary

Updated json-c to the latest version 0.13.1.

Changes:

Bump the major version of the .so library generated up to 4.0 to avoid conflicts because some downstream packagers of json-c had already done their own bump to ".so.3" for a much older 0.12 release.
Add const size_t json_c_object_sizeof()
Avoid invalid free (and thus a segfault) when ref_count gets < 0
Fix handling of custom double formats that include a ".0"
Avoid uninitialized variable warnings in json_object_object_foreach
Fix build for certain uClibc based systems.
Add a top level fuzz directory for fuzzers run by OSS-Fuzz

Test Plan

Installed and launched 'steam' which requires 'json-c-32bit' with everything working as expected.
Rebuilt and tested all the reverse dependencies of json-c successfully.

Diff Detail

Repository

R1507 json-c

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

JamesLee created this revision.Oct 27 2018, 4:09 PM

Herald added a reviewer: Triage Team. · View Herald TranscriptOct 27 2018, 4:09 PM

JamesLee requested review of this revision.Oct 27 2018, 4:09 PM

Would be good to have someone test Baldur's Gate games with this as it's the only game I'm aware of that uses this in steam. I do own the game as a last resort.

I have validated that symbols are unchanged other than json_c_object_sizeof being added.

package.yml
20	This symlink will be broken with the ABI bump

Fixed broken symlink

I don't own Baldur's Gate so I can't test it. If @sunnyflunk or someone else would be willing to test it I would be grateful.

Appears to be fine with Baldurs Gate and now I have a game to play while I'm away next week xD

That's good to hear thanks for doing the testing.

joebonrichie mentioned this in D4173: Rebuild for json-c 0.13.1.Oct 28 2018, 4:12 PM

JamesLee added a child revision: D4173: Rebuild for json-c 0.13.1.Oct 28 2018, 4:29 PM

JamesLee added a child revision: D4181: Rebuild for json-c 0.13.1.

JamesLee added a child revision: D4180: Rebuild for json-c 0.13.1.

JamesLee added a child revision: D4179: Rebuild for json-c 0.13.1.

JamesLee added a child revision: D4178: Rebuild for json-c 0.13.1.

JamesLee added a child revision: D4177: Rebuild for json-c 0.13.1.

JamesLee added a child revision: D4176: Rebuild for json-c 0.13.1.

JamesLee added a child revision: D4175: Rebuild for json-c 0.13.1.

JamesLee added a child revision: D4174: Rebuild for json-c 0.13.1.

Please avoid citing bug reports or pull requests such as Issue #396 and PR#394 to tidy up the changelog. Additionally please state you've rebuilt and tested the reverse dependencies in the test plan.

joebonrichie requested changes to this revision.Oct 28 2018, 9:42 PM

This revision now requires changes to proceed.Oct 28 2018, 9:42 PM

JamesLee edited the summary of this revision. (Show Details)Oct 28 2018, 9:45 PM

JamesLee edited the test plan for this revision. (Show Details)

joebonrichie accepted this revision.Oct 28 2018, 9:46 PM

This revision is now accepted and ready to land.Oct 28 2018, 9:46 PM

Closed by commit R1507:cd9a7b8befdc: Update json-c to 0.13.1 (authored by JamesLee, committed by joebonrichie). · Explain WhyOct 28 2018, 9:49 PM

This revision was automatically updated to reflect the committed changes.

Thanks, rebuilds went smoothly - it was nice the get the rebuilds done for me for a change!

In D4165#67032, @joebonrichie wrote:

Thanks, rebuilds went smoothly - it was nice the get the rebuilds done for me for a change!

Thanks for the help guiding me through the process for the first time. If you want somebody to help with rebuilds in the future please let me know; Ill try to be in the IRC more frequently.