Paths

Table of Contentst

Differential D4149

Enable graphical mode for X11
AbandonedPublic
Actions

Authored by Phantop on Oct 25 2018, 10:13 PM.

Tags

None

Referenced Files

	F10852862: D4149.id10243.diff
	Jun 13 2023, 6:12 AM

	F10850262: D4149.id10239.diff
	Jun 12 2023, 2:10 AM

	F10837508: D4149.id10243.diff
	Jun 9 2023, 3:48 AM

	F10786297: D4149.diff
	May 26 2023, 7:26 AM

	F10722836: D4149.diff
	May 6 2023, 10:22 PM

Subscribers

Details

Reviewers

Group Reviewers

Summary

Add depends for X11, JPEG, and PNG for graphical browsing.

Test Plan

Run and browse with X11 installed and make sure pages render as expected

Diff Detail

Repository

Branch

master

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

Phantop created this revision.Oct 25 2018, 10:13 PM

Herald added a reviewer: Triage Team. · View Herald TranscriptOct 25 2018, 10:13 PM

Phantop requested review of this revision.Oct 25 2018, 10:13 PM

JoshStrobl requested changes to this revision.Oct 25 2018, 10:18 PM

JoshStrobl added a subscriber: JoshStrobl.

JoshStrobl added inline comments.

package.yml
11	All pkgconfigs should go before all the explicitly named packages.
19–20	Unnecessary new line is unnecessary. Can put all this on one line.
20	Not necessary, this is a dependency of `libxt-devel`, see `eopkg info libxt-devel`

This revision now requires changes to proceed.Oct 25 2018, 10:18 PM

Follow guidelines

Pkgconfigs now before explicit
Remove unnecessary newline
Remove redundant libx11

File permissions shouldn't have changed.

This revision now requires changes to proceed.Nov 5 2018, 5:23 PM

Closing due to lack of movement.

Revision Contents
Changeset List

Path

Size

6 lines

7 lines

pspec_x86_64.xml

14 lines

Diff 10243

Makefile

Loading...

abi_used_libs

Loading...

package.yml

Loading...

pspec_x86_64.xml

Loading...