Page MenuHomeSolus

Enable graphical mode for X11
AbandonedPublic

Authored by Phantop on Oct 25 2018, 10:13 PM.

Details

Reviewers
JoshStrobl
Group Reviewers
Triage Team
Summary

Add depends for X11, JPEG, and PNG for graphical browsing.

Test Plan

Run and browse with X11 installed and make sure pages render as expected

Diff Detail

Repository
R1962 links
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

Phantop created this revision.Oct 25 2018, 10:13 PM
Phantop requested review of this revision.Oct 25 2018, 10:13 PM
JoshStrobl requested changes to this revision.Oct 25 2018, 10:18 PM
JoshStrobl added a subscriber: JoshStrobl.
JoshStrobl added inline comments.
package.yml
11

All pkgconfigs should go before all the explicitly named packages.

19–20

Unnecessary new line is unnecessary. Can put all this on one line.

20

Not necessary, this is a dependency of libxt-devel, see eopkg info libxt-devel

This revision now requires changes to proceed.Oct 25 2018, 10:18 PM
Phantop updated this revision to Diff 10243.Oct 26 2018, 3:33 AM

Follow guidelines

Pkgconfigs now before explicit
Remove unnecessary newline
Remove redundant libx11

JoshStrobl requested changes to this revision.Nov 5 2018, 5:23 PM

File permissions shouldn't have changed.

This revision now requires changes to proceed.Nov 5 2018, 5:23 PM
DataDrake abandoned this revision.Mar 30 2019, 8:15 PM
DataDrake added a subscriber: DataDrake.

Closing due to lack of movement.