Differential D4130

Inclusion of qt5ct
ClosedPublic
Actions

Authored by Girtablulu on Oct 23 2018, 9:38 PM.

Tags

None

Subscribers

Details

Reviewers

Group Reviewers

Maniphest Tasks

Commits

R3518:10e9ae0f5c8f: Inclusion of qt5ct

Summary

Inclusion of qt5ct. Resolves T6956

Test Plan

Changed design and started dolphin via "dolphin --platformtheme qt5ct"

Diff Detail

Repository

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

Event Timeline

Girtablulu created this revision.Oct 23 2018, 9:38 PM

Herald added a reviewer: Triage Team. · View Herald TranscriptOct 23 2018, 9:38 PM

Girtablulu requested review of this revision.Oct 23 2018, 9:38 PM

JoshStrobl requested changes to this revision.Oct 25 2018, 2:09 AM

JoshStrobl retitled this revision from Update qt5ct to 0.36 to Inclusion of qt5ct.

JoshStrobl edited the summary of this revision. (Show Details)

JoshStrobl added a subscriber: JoshStrobl.

JoshStrobl added inline comments.

package.yml
12	Not needed. This is a dep of qt5 tools.
pspec_x86_64.xml
25	And where's the desktop icons?

This revision now requires changes to proceed.Oct 25 2018, 2:11 AM

Remove not needed builddep

Still didn't address desktop icons issue.

This revision now requires changes to proceed.Oct 25 2018, 11:11 PM

JoshStrobl accepted this revision.Oct 25 2018, 11:16 PM

This revision is now accepted and ready to land.Oct 25 2018, 11:16 PM

Girtablulu added inline comments.Oct 25 2018, 11:17 PM

pspec_x86_64.xml
25	It doesn't have any own icon, it uses Icon=preferences-desktop-theme so therefore I thought it's not needed

Closed by commit R3518:10e9ae0f5c8f: Inclusion of qt5ct (authored by Girtablulu, committed by DataDrake). · Explain WhyOct 30 2018, 11:54 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
A	M		Makefile (1 line)
A	M		abi_used_libs (7 lines)
A	M		package.yml (20 lines)
A	M		pspec_x86_64.xml (48 lines)

Diff 10162

Makefile

Loading...

abi_used_libs

Loading...

package.yml

Loading...

pspec_x86_64.xml

Loading...