Page MenuHomeSolus

Inclusion of qt5ct
ClosedPublic

Authored by Girtablulu on Oct 23 2018, 9:38 PM.

Details

Reviewers
JoshStrobl
Group Reviewers
Triage Team
Maniphest Tasks
T6956: qt5ct
Commits
R3518:10e9ae0f5c8f: Inclusion of qt5ct
Summary

Inclusion of qt5ct. Resolves T6956

Test Plan

Changed design and started dolphin via "dolphin --platformtheme qt5ct"

Diff Detail

Repository
R3518 qt5ct
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Girtablulu created this revision.Oct 23 2018, 9:38 PM
Girtablulu requested review of this revision.Oct 23 2018, 9:38 PM
JoshStrobl requested changes to this revision.Oct 25 2018, 2:09 AM
JoshStrobl retitled this revision from Update qt5ct to 0.36 to Inclusion of qt5ct.
JoshStrobl edited the summary of this revision. (Show Details)
JoshStrobl added a subscriber: JoshStrobl.
JoshStrobl added inline comments.
package.yml
13

Not needed. This is a dep of qt5 tools.

pspec_x86_64.xml
26

And where's the desktop icons?

This revision now requires changes to proceed.Oct 25 2018, 2:11 AM
Girtablulu updated this revision to Diff 10222.Oct 25 2018, 8:19 AM

Remove not needed builddep

JoshStrobl requested changes to this revision.Oct 25 2018, 11:11 PM

Still didn't address desktop icons issue.

This revision now requires changes to proceed.Oct 25 2018, 11:11 PM
JoshStrobl accepted this revision.Oct 25 2018, 11:16 PM
This revision is now accepted and ready to land.Oct 25 2018, 11:16 PM
Girtablulu added inline comments.Oct 25 2018, 11:17 PM
pspec_x86_64.xml
26

It doesn't have any own icon, it uses

Icon=preferences-desktop-theme

so therefore I thought it's not needed

This revision was automatically updated to reflect the committed changes.