Update python-sqlalchemy to 1.2.14
ClosedPublic
Actions

Authored by maverick1 on Oct 23 2018, 7:32 AM.

Details

Reviewers

JoshStrobl
DataDrake

Group Reviewers

Triage Team

Commits

R2699:70aed424b8ae: Update python-sqlalchemy to 1.2.14

Summary

Updated sqlalchemy to latest version. Changelog available here.

Test Plan

Created engine and queried form the postgresql database.

Diff Detail

Repository

R2699 python-sqlalchemy

Branch

master

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

maverick1 created this revision.Oct 23 2018, 7:32 AM

Herald added a reviewer: Triage Team. · View Herald TranscriptOct 23 2018, 7:32 AM

maverick1 requested review of this revision.Oct 23 2018, 7:32 AM

Has this been tested at all against its revdeps, like gourmet and python-alembic?

This revision now requires changes to proceed.Oct 25 2018, 2:42 AM

No I haven't. But sqlalchemy is working fine in all the aspects.

I did test on alembic everything worked fine.
But during initiating it needed python-editor as dependency. I installed it from pip and from then it works fine.

maverick1 requested review of this revision.Oct 27 2018, 5:47 PM

maverick1 retitled this revision from Update python-sqlalchemy to 1.2.12 to Update python-sqlalchemy to 1.2.13.Nov 2 2018, 8:00 AM

Bumped to 1.2.13

Bumped to 1.2.14

maverick1 retitled this revision from Update python-sqlalchemy to 1.2.13 to Update python-sqlalchemy to 1.2.14.Nov 12 2018, 12:49 PM

But during initiating it needed python-editor as dependency. I installed it from pip and from then it works fine.

Then that needs to be fixed by being packaged.

This revision now requires changes to proceed.Nov 18 2018, 2:10 PM

In D4116#70058, @JoshStrobl wrote:

But during initiating it needed python-editor as dependency. I installed it from pip and from then it works fine.

Then that needs to be fixed by being packaged.

It has been fixed in https://dev.getsol.us/R4570:8a339e76cd76a9d9d3a066e965e9a6031889f0d4

then you can use it inside your package.yml, since is now official inside our repo. Users should not have to install stuff over pip to get a software running, which they can install from the solus repo

that's not its dependency. That's python alembic's the package.yml is fine.

maverick1 requested review of this revision.Nov 26 2018, 12:51 PM