Page MenuHomeSolus
Differential D4077

Update numpy to 1.15.4
ClosedPublic
Actions

Authored by maverick1 on Oct 18 2018, 9:02 AM.
Tags
None
Referenced Files
F10962325: D4077.id10586.diff
Tue, Jul 18, 9:14 PM
F10952702: D4077.id10588.diff
Sun, Jul 16, 5:46 PM
F10924208: D4077.id10032.diff
Jul 10 2023, 2:07 AM
F10916205: D4077.id10621.diff
Jul 8 2023, 10:56 AM
F10911502: D4077.id10133.diff
Jul 7 2023, 9:06 AM
F10896124: D4077.id10032.diff
Jul 1 2023, 10:09 PM
F10892123: D4077.diff
Jun 29 2023, 7:11 PM
F10820620: D4077.id.diff
Jun 2 2023, 4:54 AM
View All 9 Files
Subscribers
DataDrake
kyrios123

Details

Reviewers
DataDrake
kyrios123
Group Reviewers
Triage Team
Commits
R2189:4fc9dbc89145: Update numpy to 1.15.4
Summary

Update numpy to 1.15.4 . The Python versions supported by this release are 2.7, 3.4-3.7. The wheels are linked with OpenBLAS v0.3.0, which should fix some of the linalg problems reported for NumPy 1.14. Changelog available here.

Test Plan

Imported numpy and did numpy.test('full') in python and ran some of the machine learning regression python codes.

Diff Detail

Repository
R2189 numpy
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

maverick1 created this revision.Oct 18 2018, 9:02 AM
Herald added a reviewer: Triage Team. · View Herald TranscriptOct 18 2018, 9:02 AM
maverick1 requested review of this revision.Oct 18 2018, 9:02 AM
DataDrake requested changes to this revision.Oct 21 2018, 3:09 AM
DataDrake added a subscriber: DataDrake.
DataDrake added inline comments.
package.yml
15–16

pkgconfigs go first in the "alphabetical" ordering.

19

Why was this removed? We need those compile flags.

This revision now requires changes to proceed.Oct 21 2018, 3:09 AM
maverick1 updated this revision to Diff 10133.Oct 22 2018, 4:39 PM
maverick1 marked 2 inline comments as done.

Arranged pkgconfig in alphabetical order and added the patch again for compile flags.

DataDrake accepted this revision.Nov 5 2018, 5:42 PM

LGTM. Thanks!

This revision is now accepted and ready to land.Nov 5 2018, 5:42 PM
maverick1 updated this revision to Diff 10586.Nov 10 2018, 12:15 PM

Bumped to 1.15.4.

maverick1 retitled this revision from Update numpy to 1.15.2 to Update numpy to 1.15.4.Nov 10 2018, 12:16 PM
maverick1 edited the summary of this revision. (Show Details)
maverick1 edited the summary of this revision. (Show Details)
kyrios123 added a subscriber: kyrios123.Nov 10 2018, 1:43 PM
kyrios123 added inline comments.
package.yml
16

Why is pytest a runtime dependency of numpy now ?

maverick1 added a comment.Nov 10 2018, 1:49 PM

it needs pytest to run numpy.test since 1.15.
It written here

package.yml
19

the openblas bug was removed in this version so I thought like removing it.
Should I keep it?

kyrios123 requested changes to this revision.Nov 10 2018, 2:00 PM
In D4077#68848, @maverick1 wrote:

it needs pytest to run numpy.test since 1.15.
It written here

This is for the check step (optional) of the package, it's not needed at runtime.
Here is a patch I recently submitted for a python package that uses pytest

This revision now requires changes to proceed.Nov 10 2018, 2:00 PM
maverick1 updated this revision to Diff 10588.Nov 10 2018, 2:59 PM

Removed python-pytest from rundep and added check.

kyrios123 accepted this revision.Nov 10 2018, 4:15 PM
This revision is now accepted and ready to land.Nov 10 2018, 4:15 PM
Closed by commit R2189:4fc9dbc89145: Update numpy to 1.15.4 (authored by maverick1, committed by DataDrake). · Explain WhyNov 11 2018, 2:58 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
15 lines
424 lines

Diff 10621

View Options

package.yml

Loading...
View Options

pspec_x86_64.xml

Loading...
Copyright © 2015-2021 Solus Project. The Solus logo is Copyright © 2016-2021 Solus Project. All Rights Reserved.