Page MenuHomeSolus

Initial commit of EDuke32
AbandonedPublic

Authored by aleksvor on Oct 17 2018, 3:19 PM.

Details

Reviewers
DataDrake
Group Reviewers
Triage Team
Maniphest Tasks
T6990: EDuke32
Summary

Initial commit of EDuke32.
Resolves T6990, depends on D4068.

Test Plan

Played the following games:

  1. Duke Nukem 3D: Atomic Edition
  2. Duke3D: Duke It Out In D.C.
  3. Duke3D: Life's a Beach
  4. Duke3D: Nuclear Winter
  5. BloodCM
  6. NAM
  7. World War II GI

Diff Detail

Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
aleksvor created this revision.Oct 17 2018, 3:19 PM
aleksvor requested review of this revision.Oct 17 2018, 3:19 PM
DataDrake requested changes to this revision.Oct 21 2018, 3:11 AM
DataDrake added a subscriber: DataDrake.
DataDrake added inline comments.
package.yml
8

I'm not seeing this in SPDX or the sources, what is this?

This revision now requires changes to proceed.Oct 21 2018, 3:11 AM
aleksvor added inline comments.Oct 21 2018, 5:57 AM
package.yml
8

@DataDrake , it's a custom license, under which the source code of Build engine was originally released.
Though I'm not sure how to properly note this license in the package, considering it's not present in SPDX list. If I understood SPDX guidelines correctly, we can use the short identifier if the author provides it, and this license is often referred by author and others as BUILDLIC.

Sot sure how I feel about:

[2] Any derivative works based on my Build source may be distributed ONLY
       through the INTERNET.

We can't really enforce that :/

Sot sure how I feel about:

[2] Any derivative works based on my Build source may be distributed ONLY
       through the INTERNET.

We can't really enforce that :/

Distribution through package manager falls under "distribution through the Internet", doesn't it? Or are there another means of distribution of our packages that violate this rule?

aleksvor updated this revision to Diff 10299.Oct 28 2018, 4:37 PM
  1. Updated to the latest stable snapshot.
  2. Fixed permissions on icon file.
aleksvor edited the test plan for this revision. (Show Details)Oct 30 2018, 11:45 AM
aleksvor updated this revision to Diff 10416.Oct 31 2018, 4:19 PM

Updated to r7138.

DataDrake requested changes to this revision.Nov 5 2018, 5:45 PM
DataDrake added inline comments.
package.yml
3

Let's use the date of the version rather than the random number they have associated with it as the version.

This revision now requires changes to proceed.Nov 5 2018, 5:45 PM
aleksvor updated this revision to Diff 10492.Nov 5 2018, 6:11 PM
  1. Bump to 20181104...
  2. ...And start using date of build instead of revision number.
aleksvor updated this revision to Diff 10847.EditedNov 21 2018, 12:34 PM

Bump to 20181118

aleksvor updated this revision to Diff 11259.Dec 9 2018, 11:35 AM

Bump to 20181207.

aleksvor updated this revision to Diff 11469.Dec 16 2018, 9:00 AM

Bump to 20181215.

aleksvor updated this revision to Diff 11470.Dec 16 2018, 9:01 AM

Fixed relnum.

aleksvor updated this revision to Diff 11779.Dec 25 2018, 3:15 PM

Update to 20181223.

aleksvor updated this revision to Diff 12875.Feb 6 2019, 5:01 PM

Bump to 20190202.

DataDrake abandoned this revision.Feb 9 2019, 8:33 PM

After much deliberation we have decided that the license is unenforceable and are unwilling to take on legal responsibility for redistribution.