Differential D4051

Update pygraphviz to 1.5
ClosedPublic
Actions

Authored by padraig on Oct 16 2018, 11:47 AM.

Details

Reviewers

DataDrake

Group Reviewers

Triage Team

Commits

R3657:52dace0ba7bc: Update pygraphviz to 1.5

Summary

Update pygraphviz to latest version from 1.3. Note there was no 1.4, only a release candidate.

Test Plan

Run simple script

import pygraphviz as pgv
G=pgv.AGraph()
G.add_edge('a','b')

Diff Detail

Repository

R3657 pygraphviz

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

padraig created this revision.Oct 16 2018, 11:47 AM

Herald added a reviewer: Triage Team. · View Herald TranscriptOct 16 2018, 11:47 AM

padraig requested review of this revision.Oct 16 2018, 11:47 AM

Needs to be rebased on the existing repo...

This revision now requires changes to proceed.Oct 18 2018, 1:11 AM

Used existing repo

Apologies DataDrake, as I'd built the original package and uploaded it here I just used the version on my machine for the update, I didn't realise from the documentation that I had to clone the Solus version rather than the source. Hopefully this is okay now (I'm still fairly new to this!).

LGTM. Thanks!

This revision is now accepted and ready to land.Nov 5 2018, 5:43 PM

Looks like you missed some changes to the pspec.

This revision now requires changes to proceed.Nov 11 2018, 2:46 PM

Pspec updated!

LGTM. Thanks!

This revision is now accepted and ready to land.Nov 20 2018, 3:03 PM

Closed by commit R3657:52dace0ba7bc: Update pygraphviz to 1.5 (authored by padraig, committed by DataDrake). · Explain WhyNov 20 2018, 3:05 PM

This revision was automatically updated to reflect the committed changes.