Page MenuHomeSolus

Update pygraphviz to 1.5
ClosedPublic

Authored by padraig on Oct 16 2018, 11:47 AM.

Details

Summary

Update pygraphviz to latest version from 1.3. Note there was no 1.4, only a release candidate.

Test Plan

Run simple script

import pygraphviz as pgv
G=pgv.AGraph()
G.add_edge('a','b')

Diff Detail

Repository
R3657 pygraphviz
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

padraig created this revision.Oct 16 2018, 11:47 AM
padraig requested review of this revision.Oct 16 2018, 11:47 AM
DataDrake requested changes to this revision.Oct 18 2018, 1:11 AM
DataDrake added a subscriber: DataDrake.

Needs to be rebased on the existing repo...

This revision now requires changes to proceed.Oct 18 2018, 1:11 AM
padraig updated this revision to Diff 10225.Oct 25 2018, 9:20 AM

Used existing repo

Apologies DataDrake, as I'd built the original package and uploaded it here I just used the version on my machine for the update, I didn't realise from the documentation that I had to clone the Solus version rather than the source. Hopefully this is okay now (I'm still fairly new to this!).

DataDrake accepted this revision.Nov 5 2018, 5:43 PM

LGTM. Thanks!

This revision is now accepted and ready to land.Nov 5 2018, 5:43 PM
DataDrake requested changes to this revision.Nov 11 2018, 2:46 PM

Looks like you missed some changes to the pspec.

This revision now requires changes to proceed.Nov 11 2018, 2:46 PM
padraig updated this revision to Diff 10647.Nov 12 2018, 4:09 PM

Pspec updated!

DataDrake accepted this revision.Nov 20 2018, 3:03 PM

LGTM. Thanks!

This revision is now accepted and ready to land.Nov 20 2018, 3:03 PM
This revision was automatically updated to reflect the committed changes.