Page MenuHomeSolus

Initial commit of neko
ClosedPublic

Authored by alecbcs on Jun 15 2017, 10:47 PM.

Details

Summary

Initial commit of neko

Test Plan

Hi there, I tested the package by first going to http://nekovm.org/doc/begin and going to the Hello World section where the

neko team provides a test program.
So what I did:
     I created a document called hello.neko and wrote the simple code of $print("hello neko world !\n");
     Then I compiled the hello.neko by running (nekoc hello.neko) after that I ran the program by running
     (neko hello) which printed out the expected string of "hello neko world".

Diff Detail

Repository
R3577 neko
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

alecbcs created this revision.Jun 15 2017, 10:47 PM

I also wanted to mention that I marked the licence as Custom (Unsure) because if you go to the license page (https://github.com/HaxeFoundation/neko/blob/master/LICENSE) the Neko team does not specify what license they are using but they do give a lot of information about it. Does anyone know what this license is classified as?

Multiple licenses, MIT, Zlib, BSD-2-Clause, GPL-2.0, Apache-2.0

alecbcs updated this revision to Diff 857.Jun 15 2017, 11:21 PM

Initial commit of neko

alecbcs updated this revision to Diff 858.Jun 15 2017, 11:23 PM

Initial commit of neko

alecbcs updated this revision to Diff 859.Jun 15 2017, 11:28 PM

Initial commit of neko

alecbcs updated this revision to Diff 918.Jun 19 2017, 9:26 PM

Fixed license formatting and naming

JoshStrobl requested changes to this revision.Jun 24 2017, 5:05 PM
JoshStrobl added a subscriber: JoshStrobl.
JoshStrobl added inline comments.
package.yml
8–12

Should be alphabetized

13

Remove the newline

19–31

Some of these are part of system.devel and should be removed. Others, like apr-util-devel, have dependencies on other -devel packages, thus redundant entries should be removed as well.

This revision now requires changes to proceed.Jun 24 2017, 5:05 PM
alecbcs updated this revision to Diff 1055.Jun 24 2017, 8:04 PM
alecbcs edited edge metadata.

Alphabetized the licenses, removed the empty line, and removed packages that are found in system.devel or were dependencies of another packages.

alecbcs marked 3 inline comments as done.Jun 24 2017, 8:05 PM
JoshStrobl requested changes to this revision.Jun 24 2017, 8:07 PM

Aside from note I made, LGTM.

package.yml
18–26

These should be alphabetized as well (makes browsing through them easier), with pkgconfigs first.

This revision now requires changes to proceed.Jun 24 2017, 8:07 PM
alecbcs updated this revision to Diff 1056.Jun 24 2017, 8:15 PM
alecbcs edited edge metadata.

Alphabetized the builddeps with the package configs first.

alecbcs marked an inline comment as done.Jun 24 2017, 8:16 PM
This revision is now accepted and ready to land.Jun 24 2017, 8:18 PM
DataDrake set the repository for this revision to R3577 neko.Jul 9 2017, 8:33 PM
This revision was automatically updated to reflect the committed changes.