Page MenuHomeSolus

Initial commit of neko
ClosedPublic

Authored by alecbcs on Jun 15 2017, 10:47 PM.
Tags
None
Referenced Files
F10780829: D400.id.diff
Thu, May 25, 4:11 AM
F10764097: D400.id857.diff
Fri, May 19, 5:31 AM
F10763911: D400.id.diff
Fri, May 19, 4:11 AM
F10711487: D400.diff
Apr 29 2023, 11:40 PM
Subscribers

Details

Summary

Initial commit of neko

Test Plan

Hi there, I tested the package by first going to http://nekovm.org/doc/begin and going to the Hello World section where the

neko team provides a test program.
So what I did:
     I created a document called hello.neko and wrote the simple code of $print("hello neko world !\n");
     Then I compiled the hello.neko by running (nekoc hello.neko) after that I ran the program by running
     (neko hello) which printed out the expected string of "hello neko world".

Diff Detail

Repository
R3577 neko
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

I also wanted to mention that I marked the licence as Custom (Unsure) because if you go to the license page (https://github.com/HaxeFoundation/neko/blob/master/LICENSE) the Neko team does not specify what license they are using but they do give a lot of information about it. Does anyone know what this license is classified as?

Multiple licenses, MIT, Zlib, BSD-2-Clause, GPL-2.0, Apache-2.0

Fixed license formatting and naming

JoshStrobl added a subscriber: JoshStrobl.
JoshStrobl added inline comments.
package.yml
8–12

Should be alphabetized

13

Remove the newline

19–31

Some of these are part of system.devel and should be removed. Others, like apr-util-devel, have dependencies on other -devel packages, thus redundant entries should be removed as well.

This revision now requires changes to proceed.Jun 24 2017, 5:05 PM
alecbcs edited edge metadata.

Alphabetized the licenses, removed the empty line, and removed packages that are found in system.devel or were dependencies of another packages.

Aside from note I made, LGTM.

package.yml
18–26

These should be alphabetized as well (makes browsing through them easier), with pkgconfigs first.

This revision now requires changes to proceed.Jun 24 2017, 8:07 PM
alecbcs edited edge metadata.

Alphabetized the builddeps with the package configs first.

This revision is now accepted and ready to land.Jun 24 2017, 8:18 PM
This revision was automatically updated to reflect the committed changes.