Page MenuHomeSolus

Initial inclusion of opam

Authored by jalden on Oct 8 2018, 4:41 PM.


Group Reviewers
Triage Team
Maniphest Tasks
T3436: Opam

Initial commit of opam, fixes T3436.

Test Plan
  • Built the package with make
  • Install the produced binary artifact
  • Tested the following opam commands:
    • opam init
    • opam list
    • opam show
    • opam install
    • opam remove
    • opam update
    • opam upgrade
    • opam config
    • opam repository
    • opam switch (Tested system (currently 4.07.0), 4.07.1 and 4.02.3)
    • opam pin
    • opam admin
  • Tested that man pages were installed correctly (man opam and man opam-x where x is an opam command, for example, man opam-init)

Diff Detail

No Linters Available
No Unit Test Coverage

Event Timeline

jalden created this revision.Oct 8 2018, 4:41 PM
jalden requested review of this revision.Oct 8 2018, 4:41 PM
DataDrake requested changes to this revision.Oct 18 2018, 1:31 AM
DataDrake added a subscriber: DataDrake.
DataDrake added inline comments.

Needs to follow SPDX 3.0 License List.

This revision now requires changes to proceed.Oct 18 2018, 1:31 AM
jalden added inline comments.Oct 18 2018, 8:46 AM

Oh okay, sorry about that. How do I choose between LGPL-2.1-only and LGPL-2.1-or-later? I thought I understood the difference between them, but on the SPDX website, the license texts are identical, and they both say the following:

This library is free software; you can redistribute it and/or modify it under the terms of the GNU Library General Public License as published by the Free Software Foundation; either version 2 of the License, or (at your option) any later version.

That sounds to me like the LGPL-2.1-only license text contradicts the name of license.

Also, the OCaml license specifies an exception at the top. Does this affect the license that should be applied to it?

Here is a link to the license for reference:

This is -or-later since it has not been explicitly called out elsewhere as -only. You can ignore the license exception since afaict it doesn't apply to us.

so-lo added a subscriber: so-lo.Dec 29 2018, 11:25 PM
DataDrake abandoned this revision.Mar 30 2019, 8:16 PM

Closing due to lack of movement.