Page MenuHomeSolus

Add perl-tk to the repository
AbandonedPublic

Authored by curantes on Jun 14 2017, 10:45 PM.

Details

Summary

This package is a dependency for T2165

Signed-off-by: Matthias Eliasson <matthias.eliasson@gmail.com>

Test Plan

installed package and verified that man pages worked no errors found

Diff Detail

Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

curantes created this revision.Jun 14 2017, 10:45 PM
curantes updated this revision to Diff 838.Jun 14 2017, 10:48 PM
curantes retitled this revision from Initial commit for inclusion to Initial commit for inclusion This package is a dependency for T2165.
curantes edited the test plan for this revision. (Show Details)

Added test plan and a reference why we need to include this package

Updating D398: Initial commit for inclusion

This package is a dependency for T2165

curantes retitled this revision from Initial commit for inclusion This package is a dependency for T2165 to Initial commit for inclusion.Jun 14 2017, 10:50 PM
curantes edited the summary of this revision. (Show Details)
curantes retitled this revision from Initial commit for inclusion to Add perl-tk to the repository.Jun 14 2017, 10:52 PM
Justin requested changes to this revision.Jun 15 2017, 4:13 AM
Justin added subscribers: ikey, Justin.
Justin added inline comments.
package.yml
9

Which GPL? All licenses must be as listed here: ie GPL-3.0 or GPL-2.0 etc

10

What is the custom license? Please link it in a comment so @ikey can review.

This revision now requires changes to proceed.Jun 15 2017, 4:13 AM
curantes updated this revision to Diff 854.Jun 15 2017, 3:40 PM
curantes edited edge metadata.

Added more correctly licenses

The custom license indicate 2 extra licenses that I can't find information about in the spdx.org list.

those are: Tk and Tix part in pTk folder of the source tree.

The license files can be found in source tree:

pTk/license.terms for details of this Tk license
pTk/Tix.license for the Tix license

@ikey I hope you or someone in Triage Team can help with sorting out the license part.

Isn't it the TCL license : https://spdx.org/licenses/TCL.html

I was thinking of it and its the best fit, but I feel we need to go with what is included in the project.

Besides I have looked different distros: Arch, Debian and openSUSE and all of them seems to write different Licence info for this package. This does not make it easier :)

Justin edited reviewers, added: ikey; removed: Triage Team, Justin.Jul 2 2017, 2:34 AM

Links below to the different licenses for this package.

@ikey can you please review licenses and let me know what "custom" license in package.yaml should be.

https://github.com/eserte/perl-tk/blob/master/COPYING
https://github.com/eserte/perl-tk/blob/master/pTk/license.terms
https://github.com/eserte/perl-tk/blob/master/pTk/Tix.license

Justin removed a subscriber: Justin.Aug 24 2017, 3:12 AM

@ikey I know you have been busy, but do you have any time to look at the license issue for this?

Thanks!

joebonrichie requested changes to this revision.Oct 28 2017, 4:24 PM
joebonrichie added a subscriber: joebonrichie.
joebonrichie added inline comments.
package.yml
9
This revision now requires changes to proceed.Oct 28 2017, 4:24 PM
curantes abandoned this revision.Nov 26 2017, 7:08 PM

Please see D1454