Page MenuHomeSolus

upgrade libpinyin to 2.2.0
ClosedPublic

Authored by hashhsah on Sep 30 2018, 6:58 PM.

Details

Summary
Test Plan

install and use it with ibus-pinyin and fcitx-pinyin

Diff Detail

Repository
R1819 libpinyin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
hashhsah created this revision.Sep 30 2018, 6:58 PM
hashhsah requested review of this revision.Sep 30 2018, 6:58 PM
DataDrake accepted this revision.Oct 18 2018, 1:34 AM
DataDrake added a subscriber: DataDrake.

LGTM. Thanks!

This revision is now accepted and ready to land.Oct 18 2018, 1:34 AM
DataDrake requested changes to this revision.Oct 18 2018, 2:03 AM
configure: error: Cannot find Berkeley DB library version 4
This revision now requires changes to proceed.Oct 18 2018, 2:03 AM

I see that libpinyin depends on Berkeley db 5, which is in the base image. According to abi_used_libs, it has always been depending on bdb5.
I don't understand why it requires bdb 4 in your build environment. Could it be some package in local repo?

sunnyflunk added a subscriber: sunnyflunk.EditedOct 18 2018, 6:05 AM

@hashhsah with the updated images db5-devel is no longer part of the solbuild image, so this dependency will need to be added.

I suggest you follow this guide https://getsol.us/articles/packaging/moving-to-getsolus/en/#solbuild-images to remove and reinitialize your solbuild image to ensure you are matching building with the same dependencies as the build server (there was about 5 -devel packages removed which can't be removed through updates).

hashhsah updated this revision to Diff 10039.Oct 18 2018, 12:48 PM

fix builddep: bdb5

DataDrake accepted this revision.Oct 21 2018, 2:57 AM
DataDrake added a project: Requires Rebuilds.

LGTM. Thanks!

This revision is now accepted and ready to land.Oct 21 2018, 2:57 AM
Closed by commit R1819:6a563f1d9931: upgrade libpinyin to 2.2.0 (authored by hash <hashhsah@gmail.com>, committed by JoshStrobl). · Explain WhyOct 25 2018, 2:47 AM
This revision was automatically updated to reflect the committed changes.