Paths

Table of Contentst

Differential D3943

Update Samba from the 4.7.x branch to the 4.8.x branch (T6851).
ClosedPublic
Actions

Authored by ermo on Sep 29 2018, 12:25 PM.

Tags

None

Referenced Files

	F11008241: D3943.diff
	Wed, Aug 2, 1:41 AM

	F10922942: D3943.id9754.diff
	Sun, Jul 9, 8:50 PM

	F10906354: D3943.id10189.diff
	Jul 6 2023, 9:35 AM

	F10869807: D3943.diff
	Jun 18 2023, 6:31 AM

	F10852699: D3943.id10189.diff
	Jun 13 2023, 3:40 AM

	F10851725: D3943.id10187.diff
	Jun 12 2023, 3:46 PM

	F10848139: D3943.id10121.diff
	Jun 11 2023, 1:38 PM

	F10847036: D3943.id10184.diff
	Jun 11 2023, 8:43 AM

View All 22 Files

Subscribers

Details

Reviewers

Group Reviewers

Maniphest Tasks

T6851: Update Samba to 4.8.6 (from the previous 4.7.x branch)

Commits

R2842:5db3478c63bb: Update Samba from the 4.7.x branch to the 4.8.x branch (T6851).

Summary

The default Solus Samba configuration is targeted at small home networks.

In addition to moving to a newer stable Samba branch, this update disables the previously enabled Active Directory Domain Controller functionality since Solus is not intended for use (nor tested) in an Enterprise environment -- neither as an AD DC server nor as a client in an AD DC environment.

4.8.x feature highlights relevant to the default Solus Samba config:

Time Machine Support with vfs_fruit
Support for lower casing the MDNS Name

Build and configuration changes from 4.7.x:

Disable the Active Directory Domain Controller functionality since Solus is a Personal Computing -- as opposed to Enterprise -- Client OS. In addition, the AD DC functionality was never tested to work on Solus. Has the additional benefit of removing the confusing 'samba.service' systemd service file (see T6659).
Change permissions on /var/lib/samba/private from 0755 to 0700 (like fedora)
No-op reorganization of build option order to improve readability
Use Samba's own build scripts to install systemd units
Depends on updates to talloc (D3937), tevent (D3938), tdb (D3941) and ldb (D3940). As far as I can tell these buildreq changes only add ABI symbols (no apparent symbol removals).

Release Notes:

Closes T6851

Test Plan

Build updated samba against tevent-0.9.37, tdb-1.3.16 and ldb-1.3.6
Test that sudo systemctl disable --now smb ; sudo systemct status smb ; sudo systemctl enable --now smb ; sudo systemctl status works
Test that smbclient -L -N localhost successfully connects to localhost
Recompile gvfs-1.36.2 against updated samba, reboot and check that Nautilus can connect to both anonymous and authenticated shares

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ermo created this revision.Sep 29 2018, 12:25 PM

Herald added a reviewer: Triage Team. · View Herald TranscriptSep 29 2018, 12:25 PM

ermo requested review of this revision.Sep 29 2018, 12:25 PM

ermo updated this revision to Diff 9754.Sep 29 2018, 12:33 PM

This comment was removed by ermo.

ermo mentioned this in T6851: Update Samba to 4.8.6 (from the previous 4.7.x branch).Sep 29 2018, 12:34 PM

ermo edited the summary of this revision. (Show Details)

ermo added a task: T6851: Update Samba to 4.8.6 (from the previous 4.7.x branch).

JoshStrobl mentioned this in T6939: Samba bug: Can not delete non empty folder..Oct 16 2018, 10:02 PM

Update link in smb.conf.README to new getsol.us domain.

Update package.yml comments to reflect new configuration choices.

ermo updated this revision to Diff 10184.Oct 24 2018, 4:58 PM

This comment was removed by ermo.

ermo edited the summary of this revision. (Show Details)Oct 24 2018, 5:06 PM

ermo edited the test plan for this revision. (Show Details)

Update to 4.8.6
Update setup phase to use upstream systemd units
Change back from waf command to %make macro, since upstream fixed make -jN
Update default smb.conf.solus file to make testparm complain less

kyrios123 added a subscriber: kyrios123.Oct 24 2018, 5:22 PM

kyrios123 added inline comments.

files/samba.tmpfiles
3	Isn't 100 the GID of the `users` group ? If so, any reason for not using the group name ?

ermo edited the summary of this revision. (Show Details)Oct 24 2018, 5:40 PM

Update to 4.8.6
Update setup phase to use upstream systemd units
Change back from waf command to %make macro, since upstream fixed make -jN
Update default smb.conf.solus file to make testparm complain less
Add proper description for systemd tmpfiles trick with users group (gid=100)

ermo edited the summary of this revision. (Show Details)Oct 24 2018, 6:11 PM

Update to 4.8.6 + various fixes and cleanups

Update setup phase to use upstream systemd units
Change back from waf command to %make macro, since upstream fixed make -jN
Update default smb.conf.solus file to make testparm complain less
Add proper description for systemd tmpfiles trick with users group (gid=100)

JoshStrobl accepted this revision.Oct 24 2018, 10:03 PM

This revision is now accepted and ready to land.Oct 24 2018, 10:03 PM

Closed by commit R2842:5db3478c63bb: Update Samba from the 4.7.x branch to the 4.8.x branch (T6851). (authored by ermo, committed by JoshStrobl). · Explain WhyOct 24 2018, 10:30 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

187 lines

9 lines

files/

14 lines

smb.conf.README

2 lines

6 lines

40 lines

pspec_x86_64.xml

268 lines

Diff 10200

abi_symbols

Loading...

abi_used_libs

Loading...

files/samba.tmpfiles

Loading...

files/smb.conf.README

Loading...

files/smb.conf.solus

Loading...

package.yml

Loading...

pspec_x86_64.xml

Loading...