Page MenuHomeSolus

initial package for moolticute
ClosedPublic

Authored by suntorytimed on Sep 28 2018, 8:46 AM.

Details

Summary
  • The inclusion of moolticute fixes T6903
  • initial support for the moolticute app on Solus
Test Plan

compile, install, execute moolticute and use a Mooltipass

Diff Detail

Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

suntorytimed created this revision.Sep 28 2018, 8:46 AM
suntorytimed requested review of this revision.Sep 28 2018, 8:46 AM
JoshStrobl requested changes to this revision.Sep 28 2018, 11:33 AM
JoshStrobl added a subscriber: JoshStrobl.
JoshStrobl added inline comments.
package.yml
8

Should be security.utils

16–17

Redundant, you already have pkgconfig(Qt5UiTools) which depends on qt5-base-devel

19

Redundant, you already have pkgconfig(Qt5UiTools) which depends on qt5-base-devel

21–22

Patch is likely unnecessary if you just pass -prefix /usr in your qmake macro.

This revision now requires changes to proceed.Sep 28 2018, 11:33 AM
sunnyflunk added inline comments.
package.yml
21–22

I think you mean pass PREFIX=/usr since it's qmake xD

JoshStrobl added inline comments.Sep 28 2018, 12:03 PM
package.yml
21–22

Can confirm. Derp.

suntorytimed updated this revision to Diff 9772.Oct 1 2018, 4:57 AM

applying changes according to review

suntorytimed marked 6 inline comments as done.Oct 1 2018, 4:58 AM
suntorytimed added inline comments.
package.yml
21–22

Didn't know that I have to put it at the end of the qmake line :D Tried using it the wrong way all the time (^^;)

JoshStrobl accepted this revision.Oct 4 2018, 11:00 AM
This revision is now accepted and ready to land.Oct 4 2018, 11:00 AM
This revision was automatically updated to reflect the committed changes.