Page MenuHomeSolus

Upgrade klayout to 0.25.4
ClosedPublic

Authored by hashhsah on Sep 13 2018, 6:05 PM.

Details

Summary

klayout 0.25.4 was released. It requires a patch to compile.

Changelog: https://www.klayout.de/development.html

Test Plan

Open a few GDS files (kB to GB in size) and browse the layout.

Diff Detail

Repository
R3851 klayout
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

hashhsah created this revision.Sep 13 2018, 6:05 PM
hashhsah requested review of this revision.Sep 13 2018, 6:05 PM

After submission, I'm not sure why abireport added the following lines to abi_used_libs. I'm pretty sure Qt4 wasn't even present in the chroot build environment.

libQtCore.so.4
libQtDesigner.so.4
libQtGui.so.4
libQtNetwork.so.4
libQtSql.so.4
libQtXml.so.4
libc.so.6
libdl.so.2

After submission, I'm not sure why abireport added the following lines to abi_used_libs. I'm pretty sure Qt4 wasn't even present in the chroot build environment.

libQtCore.so.4
libQtDesigner.so.4
libQtGui.so.4
libQtNetwork.so.4
libQtSql.so.4
libQtXml.so.4
libc.so.6
libdl.so.2

Perhaps try specifying qt5 explicitly.

./build.sh -dry-run -qt5

package.yml
27

Can combine these two lines to:

%make -C build-release

I find it mysterious. The build log shows the following dependency discovery (Qt5 only) :

[Dependency] /usr/lib64/libklayout_ant.so.0 adds dependency on libQt5Gui.so.5 from qt5-base
[Dependency] /usr/lib64/libklayout_ant.so.0 adds dependency on libm.so.6 from glibc
[Dependency] /usr/lib64/libklayout_ant.so.0 adds dependency on libQt5Widgets.so.5 from qt5-base
[Dependency] /usr/lib64/libklayout_ext.so.0 adds dependency on libQt5Xml.so.5 from qt5-base
[Dependency] /usr/lib64/libklayout_gsiqt.so.0 adds dependency on libQt5MultimediaWidgets.so.5 from qt5-multimedia
[Dependency] /usr/lib64/libklayout_gsiqt.so.0 adds dependency on libQt5Svg.so.5 from qt5-svg
[Dependency] /usr/lib64/libklayout_gsiqt.so.0 adds dependency on libQt5XmlPatterns.so.5 from qt5-xmlpatterns
[Dependency] /usr/lib64/libklayout_gsiqt.so.0 adds dependency on libQt5Multimedia.so.5 from qt5-multimedia
[Dependency] /usr/lib64/libklayout_gsiqt.so.0 adds dependency on libQt5Sql.so.5 from qt5-base
[Dependency] /usr/lib64/libklayout_gsiqt.so.0 adds dependency on libQt5Designer.so.5 from qt5-tools
[Dependency] /usr/lib64/libklayout_gsiqt.so.0 adds dependency on libQt5PrintSupport.so.5 from qt5-base
[Dependency] /usr/lib64/libklayout_gsiqt.so.0 adds dependency on libQt5Network.so.5 from qt5-base
[Dependency] /usr/lib64/libklayout_lay.so.0 adds dependency on libpthread.so.0 from glibc
[Dependency] /usr/lib64/libklayout_pya.so.0 adds dependency on libpython3.6m.so.1.0 from python3
[Dependency] /usr/lib64/libklayout_rba.so.0 adds dependency on libruby.so.2.3 from ruby
[Dependency] /usr/lib64/libklayout_tl.so.0 adds dependency on libz.so.1 from zlib

However, the produced abi_used_libs contains Qt4 stuff (e.g. libQtGui.so.4)

libQt5Core.so.5
libQt5Designer.so.5
libQt5Gui.so.5
libQt5Multimedia.so.5
libQt5MultimediaWidgets.so.5
libQt5Network.so.5
libQt5PrintSupport.so.5
libQt5Sql.so.5
libQt5Svg.so.5
libQt5Widgets.so.5
libQt5Xml.so.5
libQt5XmlPatterns.so.5
libQtCore.so.4
libQtDesigner.so.4
libQtGui.so.4
libQtNetwork.so.4
libQtSql.so.4
libQtXml.so.4
libc.so.6
libdl.so.2
libgcc_s.so.1
libm.so.6
libpthread.so.0
libpython3.6m.so.1.0
libruby.so.2.3
libstdc++.so.6
libz.so.1

The explicit ./build.sh -dry-run -qt5 doesn't make a difference.

hashhsah updated this revision to Diff 9771.Sep 30 2018, 8:32 PM
hashhsah edited the summary of this revision. (Show Details)

removed old .eopkg files in the directory, such that abireport does not
report dependencies on Qt4, which was used by the older klayout builds.

sunnyflunk retitled this revision from upgrade klayout to 0.25.4 to Upgrade klayout to 0.25.4.Oct 1 2018, 6:27 AM

removed old .eopkg files in the directory, such that abireport does not
report dependencies on Qt4, which was used by the older klayout builds.

Ahhh that would do it. I didn't want to push this till I had a chance to look at what was going on. LGTM

sunnyflunk accepted this revision.Oct 1 2018, 6:29 AM
This revision is now accepted and ready to land.Oct 1 2018, 6:29 AM
This revision was automatically updated to reflect the committed changes.