Page MenuHomeSolus

initial package of libnitrokey
ClosedPublic

Authored by suntorytimed on Sep 11 2018, 12:38 PM.

Details

Summary
  • dependency for nitrokey-app
  • necessary to fix T4080
Test Plan

compile libnitrokey and then nitrokey-app. Installing libnitrokey and nitrokey-app and plugging in a Nitrokey Pro -> check if it is recognized

Diff Detail

Repository
R4517 libnitrokey
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

suntorytimed requested review of this revision.Sep 11 2018, 12:38 PM
suntorytimed created this revision.

sorted builddeps alphabetically

remove unnecessary builddeps

JoshStrobl requested changes to this revision.Sep 19 2018, 6:07 AM
JoshStrobl added a subscriber: JoshStrobl.
JoshStrobl added inline comments.
package.yml
7

This is not accurate. As per our document, you should be using -or-later unless explicitly stated by the developer that it should be -only. Furthermore, their license headers state:

* libnitrokey is free software: you can redistribute it and/or modify
* it under the terms of the GNU Lesser General Public License as published by
* the Free Software Foundation, either version 3 of the License, or
* any later version.
15

You should be using the pkgconfig for this.

This revision now requires changes to proceed.Sep 19 2018, 6:07 AM

applying changes according to review

suntorytimed marked 2 inline comments as done.Sep 24 2018, 8:56 AM

Done all requested changes.

JoshStrobl accepted this revision.Sep 28 2018, 8:08 AM

LGTM, thanks!

This revision is now accepted and ready to land.Sep 28 2018, 8:08 AM
This revision was automatically updated to reflect the committed changes.