Page MenuHomeSolus

Initial inclusion of cppcodec
ClosedPublic

Authored by suntorytimed on Sep 11 2018, 12:37 PM.

Details

Summary

Initial inclusion of cppcodec, a build dependency of nitrokey-app.

Test Plan

compile cppcodec, compile nitrokey-app with dependency pkgconfig(cppcodec-1)

Diff Detail

Repository
R4516 cppcodec
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

suntorytimed requested review of this revision.Sep 11 2018, 12:37 PM
suntorytimed created this revision.

remove unnecessary builddeps

JoshStrobl requested changes to this revision.Sep 19 2018, 6:09 AM
JoshStrobl retitled this revision from build dependency for nitrokey-app to Initial inclusion of cppcodec.
JoshStrobl edited the summary of this revision. (Show Details)
JoshStrobl added a subscriber: JoshStrobl.
JoshStrobl added inline comments.
pspec_x86_64.xml
17

Given these are only headers, you should be patterning all of this into the main package. A -devel sub-package for this is not necessary. See https://getsol.us/articles/packaging/packaging-practices/en/#patterns

Likely - /, - /* or similar would be sufficient

This revision now requires changes to proceed.Sep 19 2018, 6:11 AM
This comment was removed by suntorytimed.
suntorytimed added inline comments.Sep 24 2018, 8:57 AM
pspec_x86_64.xml
17

So the final package should be called cppcodec instead of cppcodec-devel? This is only a development library though.

suntorytimed added inline comments.Sep 24 2018, 9:07 AM
pspec_x86_64.xml
17

At least according to https://getsol.us/articles/packaging/packaging-practices/en/#the-devel-subpackage the devel subpackage should be used for packages that provide libraries and development headers.

JoshStrobl added inline comments.Sep 28 2018, 8:09 AM
pspec_x86_64.xml
17

I understand what it says, I wrote the doc :P If it's just headers, then the split isn't necessary.

remove -devel subpackage

JoshStrobl accepted this revision.Sep 28 2018, 8:12 AM

Thanks for the quick response :)

This revision is now accepted and ready to land.Sep 28 2018, 8:12 AM
This revision was automatically updated to reflect the committed changes.