Differential D379

Update to 5.5.5
ClosedPublic
Actions

Authored by BridouZ on Jun 13 2017, 1:05 PM.

Details

Reviewers

• sunnyflunk

Group Reviewers

Triage Team

Commits

R3087:2bfd64c50a43: Update to 5.5.5

Summary

Update unrar to 5.5.5

Test Plan

Installation > OK
Extract content from rar archive > OK

Diff Detail

Repository

R3087 unrar

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

BridouZ created this revision.Jun 13 2017, 1:05 PM

Herald added a reviewer: Triage Team. · View Herald TranscriptJun 13 2017, 1:05 PM

Update the Differential from unrar 5.5.4 to 5.5.5

This broke on your 2nd update. It is now only showing the changes from 5.5.4 to 5.5.5 (so it won't apply, while it needs to show 5.4.5 (what's in the repo) -> 5.5.5

Perhaps you didn't --amend the commit

This revision now requires changes to proceed.Jun 18 2017, 11:41 PM

also check the version of unrar after it's compiled.
(I also did package it but I didn't submit it because the version of the binary didn't match the version of the archive which I found quite weird).