Page MenuHomeSolus

Update astroid to 0.14
ClosedPublic

Authored by hashhsah on Sep 4 2018, 5:09 PM.

Details

Summary

There is a known bug in 0.13 with webkit2gtk-2.20.5.
The new release fixes it.

I withdraw the previoius proposal to export XAPIAN_CJK_NGRAM in astroid's desktop file.
After discussing with notmuch developers, I think this should be a notmuch database
config option. Workarounds in astroid aren't good idea.

Changelog: https://github.com/astroidmail/astroid/blob/master/History.txt

Test Plan

open astroid, read and search a few emails with English and Chinese text.

Diff Detail

Repository
R4118 astroid
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
hashhsah created this revision.Sep 4 2018, 5:09 PM
hashhsah requested review of this revision.Sep 4 2018, 5:09 PM
JoshStrobl requested changes to this revision.Sep 22 2018, 9:10 AM
JoshStrobl added a subscriber: JoshStrobl.
JoshStrobl added inline comments.
files/0001-env-var-for-CJK-char.patch
8 ↗(On Diff #9382)

This is the incorrect way to solve this. Rather, we should be exporting a variable in something like /usr/share/defaults/etc/profile.d/70-astroid.sh, so it's stateless and is taken by running astroid via the CLI as well. See R3392 as an example.

This revision now requires changes to proceed.Sep 22 2018, 9:10 AM

One point of concern:
If we take the /etc/profile.d appraoch, once astroid is installed on that machine, all applications using the xapian library will see XAPIAN_CJK_NGRAM=1.
I'm afraid this would surprise users who have been using xapian prior to installing astroid.

hashhsah updated this revision to Diff 9974.Oct 16 2018, 2:20 PM
hashhsah retitled this revision from set environment variable at startup, to speed-up CJK indexing/searching. to Update astroid to 0.14.
hashhsah edited the summary of this revision. (Show Details)
hashhsah removed a reviewer: JoshStrobl.

update to 0.14; withdraw previous proposal tto export XAPIAN_CJK_NGRAM

btw, astroid uses scdoc or ronn to build man page. neither is available in solus yet, so skipping docs for now.

DataDrake accepted this revision.Oct 21 2018, 2:57 AM
DataDrake added a subscriber: DataDrake.

LGTM. Thanks!

This revision is now accepted and ready to land.Oct 21 2018, 2:57 AM
Closed by commit R4118:b8c75ff0fd3a: Update astroid to 0.14 (authored by hash <hashhsah@gmail.com>, committed by JoshStrobl). · Explain WhyOct 25 2018, 2:44 AM
This revision was automatically updated to reflect the committed changes.