Page MenuHomeSolus

Initial commit of msodbcsql
ClosedPublic

Authored by der_eismann on Sep 3 2018, 2:30 PM.

Details

Summary

Include Microsoft ODBC SQL drivers for the PHP modules.

Test Plan
  • Copy contents of /etc/msodbcsql/odbcinst.ini to /etc/odbcinst.ini
  • Execute sqlcmd
$ sqlcmd -S 192.168.103.66 -U sysop -P "password"
1> select * from dbo.MSreplication_options
2> GO
optname                                                                                                                          value major_version minor_version revision    install_failures
-------------------------------------------------------------------------------------------------------------------------------- ----- ------------- ------------- ----------- ----------------
transactional                                                                                                                        1            90             0           0                0
merge                                                                                                                                1            90             0           0                0
security_model                                                                                                                       1            90             0           0                0

(3 rows affected)

Diff Detail

Repository
R4606 msodbcsql
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

der_eismann created this revision.Sep 3 2018, 2:30 PM
der_eismann requested review of this revision.Sep 3 2018, 2:30 PM
der_eismann edited the test plan for this revision. (Show Details)Sep 4 2018, 11:25 AM

Copy contents of /etc/msodbcsql/odbcinst.ini to /etc/odbcinst.ini

Then why aren't we just installing there in the first place?

JoshStrobl requested changes to this revision.Sep 19 2018, 7:36 AM
JoshStrobl added inline comments.
package.yml
20

%apply_patches and files/series aren't necessary. It's a single file.

This revision now requires changes to proceed.Sep 19 2018, 7:36 AM
der_eismann updated this revision to Diff 9866.Oct 10 2018, 8:01 AM

Changing patch and updating package

der_eismann marked an inline comment as done.Oct 10 2018, 8:03 AM

Copy contents of /etc/msodbcsql/odbcinst.ini to /etc/odbcinst.ini
Then why aren't we just installing there in the first place?

The file /etc/odbcinst.ini is already part of the package unixodbc, I think it's meant to be manually modified.

DataDrake accepted this revision.Dec 11 2018, 4:20 AM
DataDrake added a subscriber: DataDrake.

LGTM. Thanks!

JoshStrobl accepted this revision.Dec 11 2018, 4:21 AM
This revision is now accepted and ready to land.Dec 11 2018, 4:21 AM
This revision was automatically updated to reflect the committed changes.