Page MenuHomeSolus

Inclusion of mycroft-core version 18.2.9 (T4276)
ClosedPublic

Authored by clivejo on Aug 31 2018, 11:18 PM.

Details

Summary

Inclusion of mycroft-core (T4276)

Test Plan

Install mycroft-core, start the services as local user, pair with home.mycroft.ai following the spoken instructions and pairing code. Use mycroft to control your computer via your voice.

Diff Detail

Repository
R4645 mycroft-core
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
clivejo created this revision.Aug 31 2018, 11:18 PM
clivejo requested review of this revision.Aug 31 2018, 11:18 PM
JoshStrobl requested changes to this revision.Sep 22 2018, 9:15 AM
JoshStrobl added a subscriber: JoshStrobl.

From what I can see, Mycroft needs some serious changes in order to make it fit with the our approach of statelessness, packaging, and sane methods for the automatic creation of configuration (typically the responsibility of the binary itself). Unfortunately Mycroft can't go in at its current state.

files/SKILLS_README.md
1–22 ↗(On Diff #9335)
  1. We do not support using opt in a system package.
  2. I'd rather we have documentation on the Help Center for Mycroft.
files/create-initial-user-configuration.sh
1–21 ↗(On Diff #9335)

This should really just be handled by mycroft itself, I don't see any reason we should need to do this.

files/mycroft-bus.service
10

Why isn't this just something that the binary itself handles? Seems like a hackjob if you ask me.

package.yml
87–89

Nope nope nope. No /opt.

This revision now requires changes to proceed.Sep 22 2018, 9:15 AM
clivejo updated this revision to Diff 9657.Sep 24 2018, 7:09 PM

Removing hackery to get things working out-of-the-box

DataDrake accepted this revision.Dec 31 2018, 4:48 PM
DataDrake added a subscriber: DataDrake.

LGTM. Thanks!

This revision was not accepted when it landed; it landed in state Needs Review.Jan 8 2019, 3:43 AM
Closed by commit R4645:021d00e4910e: Inclusion of mycroft-core version 18.2.9 (T4276) (authored by Clive Johnston <clivejo@protonmail.com>, committed by DataDrake). · Explain Why
This revision was automatically updated to reflect the committed changes.