Page MenuHomeSolus

Inclusion of mimic, needed for mycroft-core (T4276)
ClosedPublic

Authored by clivejo on Aug 25 2018, 9:33 PM.

Details

Summary

Inclusion of mimic, a dependency mycroft-core (T4276)

Test Plan

Install mycroft-core which uses mimic for TTS

Diff Detail

Repository
R4475 mimic
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

clivejo created this revision.Aug 25 2018, 9:33 PM
clivejo requested review of this revision.Aug 25 2018, 9:33 PM
DataDrake accepted this revision.Aug 26 2018, 3:06 PM
DataDrake added a subscriber: DataDrake.

LGTM. I'll disable static libs after land if possible. Kep an eye out for those .a files.

This revision is now accepted and ready to land.Aug 26 2018, 3:06 PM
This revision was automatically updated to reflect the committed changes.

Needed to add --enable-shared to the %autogen macro. Make sure you get that change locally.