Paths

Table of Contentst

Differential D3682

Update docker to 18.06.1 and enable manpages
ClosedPublic
Actions

Authored by der_eismann on Aug 24 2018, 8:31 PM.

Tags

None

Referenced Files

	F11007591: D3682.diff
	Tue, Aug 1, 9:04 PM

	F10976162: D3682.diff
	Sat, Jul 22, 8:02 AM

	F10897082: D3682.diff
	Jul 2 2023, 4:20 AM

	F10869120: D3682.diff
	Jun 18 2023, 2:31 AM

	F10781995: D3682.id.diff
	May 25 2023, 11:14 AM

	F10739563: D3682.diff
	May 13 2023, 8:27 PM

	F10737348: D3682.id9136.diff
	May 13 2023, 3:41 AM

	F10737012: D3682.diff
	May 13 2023, 1:32 AM

View All 12 Files

Subscribers

Details

Reviewers

Group Reviewers

Maniphest Tasks

T1807: docker man pages

Commits

R649:0f8f5de489e7: Update docker to 18.06.1 and enable manpages

Summary

Changes:

Various shell completion script updates
Fix DOCKER_CONFIG warning message and fallback search
Fix help message flags on docker stack commands and sub-commands
Set BuildKit's ExportedProduct variable to show useful errors

Also build manpages to fix T1807.

Test Plan

Run docker run hello-world
Run man docker

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

der_eismann created this revision.Aug 24 2018, 8:31 PM

Herald added a reviewer: Triage Team. · View Herald TranscriptAug 24 2018, 8:31 PM

der_eismann requested review of this revision.Aug 24 2018, 8:31 PM

der_eismann added parent revisions: D3681: Initial commit of go-md2man, D3680: Update containerd to 1.1.3.Aug 24 2018, 8:32 PM

JoshStrobl requested changes to this revision.Aug 25 2018, 11:33 AM

JoshStrobl added a subscriber: JoshStrobl.

JoshStrobl added inline comments.

package.yml
93	00644 not 00755

This revision now requires changes to proceed.Aug 25 2018, 11:33 AM

der_eismann added inline comments.Aug 25 2018, 1:08 PM

package.yml

This is just for the folder, isn't it?

sysop@eismann-pc ~ $ LC_ALL=C stat /usr/share/man
  File: /usr/share/man
  Size: 4096      	Blocks: 8          IO Block: 4096   directory
Device: 802h/2050d	Inode: 3022049     Links: 34
Access: (0755/drwxr-xr-x)  Uid: (    0/    root)   Gid: (    0/    root)

Right but the file permissions are -rw-r--r--, which is 0644. /usr/share/man/* is 755 however we're not creating those directories on installation since they already exist.

kyrios123 added a subscriber: kyrios123.Aug 25 2018, 2:59 PM

kyrios123 added inline comments.

package.yml
94	Here is my alternative suggestion for i in 1 5 8; do install -D -m 00644 components/cli/man/man$i/*.$i -t $installdir/usr/share/man/man$i done

JoshStrobl added inline comments.Aug 25 2018, 3:02 PM

package.yml
94	If we could stop separating `-D` and '-m` that'd be great. Go with `-Dm00644`

Changing file permissions

As you wish! I really just copied from another package, I'm not that used to install.

JoshStrobl accepted this revision.Aug 25 2018, 6:26 PM

This revision is now accepted and ready to land.Aug 25 2018, 6:26 PM

Closed by commit R649:0f8f5de489e7: Update docker to 18.06.1 and enable manpages (authored by der_eismann, committed by JoshStrobl). · Explain WhyAug 25 2018, 6:30 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

38 lines

pspec_x86_64.xml

20 lines

Diff 9167

package.yml

Loading...

pspec_x86_64.xml

Loading...