Page MenuHomeSolus

Update docker to 18.06.1 and enable manpages
ClosedPublic

Authored by der_eismann on Aug 24 2018, 8:31 PM.

Details

Summary

Changes:

  • Various shell completion script updates
  • Fix DOCKER_CONFIG warning message and fallback search
  • Fix help message flags on docker stack commands and sub-commands
  • Set BuildKit's ExportedProduct variable to show useful errors

Also build manpages to fix T1807.

Test Plan
  • Run docker run hello-world
  • Run man docker

Diff Detail

Repository
R649 docker
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
der_eismann created this revision.Aug 24 2018, 8:31 PM
der_eismann requested review of this revision.Aug 24 2018, 8:31 PM
JoshStrobl requested changes to this revision.Aug 25 2018, 11:33 AM
JoshStrobl added a subscriber: JoshStrobl.
JoshStrobl added inline comments.
package.yml
93

00644 not 00755

This revision now requires changes to proceed.Aug 25 2018, 11:33 AM
der_eismann added inline comments.Aug 25 2018, 1:08 PM
package.yml
93

This is just for the folder, isn't it?

sysop@eismann-pc ~ $ LC_ALL=C stat /usr/share/man
  File: /usr/share/man
  Size: 4096      	Blocks: 8          IO Block: 4096   directory
Device: 802h/2050d	Inode: 3022049     Links: 34
Access: (0755/drwxr-xr-x)  Uid: (    0/    root)   Gid: (    0/    root)

Right but the file permissions are -rw-r--r--, which is 0644. /usr/share/man/* is 755 however we're not creating those directories on installation since they already exist.

kyrios123 added inline comments.
package.yml
94

Here is my alternative suggestion

for i in 1 5 8; do
    install -D -m 00644 components/cli/man/man$i/*.$i -t $installdir/usr/share/man/man$i
done
JoshStrobl added inline comments.Aug 25 2018, 3:02 PM
package.yml
94

If we could stop separating -D and '-m` that'd be great. Go with -Dm00644

der_eismann updated this revision to Diff 9162.Aug 25 2018, 6:18 PM

Changing file permissions

der_eismann marked 4 inline comments as done.Aug 25 2018, 6:19 PM

As you wish! I really just copied from another package, I'm not that used to install.

JoshStrobl accepted this revision.Aug 25 2018, 6:26 PM
This revision is now accepted and ready to land.Aug 25 2018, 6:26 PM
This revision was automatically updated to reflect the committed changes.