Page MenuHomeSolus

Update xorg-driver-input-libinput to 0.25.1
ClosedPublic

Authored by kyrios123 on Jun 9 2017, 8:29 PM.

Details

Summary
Post a motion event after proximity events

This patch splits the meat of xf86libinput_handle_tablet_axis into a helper
function xf86libinput_post_tablet_motion(), to be called right after we send
the proximity in event.
  
Clients that don't handle proximity (e.g. all XI2 clients) don't see the
coordinates we send along with the proximity events. And, for historical
reasons, they may not look at the coordinates in button events. So a device
that comes into proximity and immediately sends a tip down button event
doesn't send a motion event, causing the client to think the tip down was at
whatever the last known position was (before previous prox-out).
  
The practical effect is that when a user tries to draw a few dots, they end up
being connected to each other.

https://bugzilla.redhat.com/show_bug.cgi?id=1433755

Ref task T3858

Signed-off-by: Pierre-Yves <pyu@riseup.net>

Test Plan

Installed, rebooted. Didn't notice any difference.

Diff Detail

Repository
R3252 xorg-driver-input-libinput
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

kyrios123 created this revision.Jun 9 2017, 8:29 PM
kyrios123 edited the summary of this revision. (Show Details)Jun 9 2017, 8:31 PM
kyrios123 edited the summary of this revision. (Show Details)
sunnyflunk accepted this revision.Jun 14 2017, 12:28 AM
sunnyflunk added a subscriber: sunnyflunk.

LGTM, thanks

This revision is now accepted and ready to land.Jun 14 2017, 12:28 AM
This revision was automatically updated to reflect the committed changes.