Page MenuHomeSolus

Update cython to 0.28.5
ClosedPublic

Authored by kyrios123 on Aug 17 2018, 4:13 PM.

Details

Summary
  • The discouraged usage of GCC's attribute optimize("Os") was replaced by the similar attribute cold to reduce the code impact of the module init functions.
  • A reference leak in Py2.x was fixed when comparing str to unicode for equality.
  • Reallowing tp_clear() in a subtype of an @no_gc_clear extension type generated an invalid C function call to the (non-existent) base type implementation.
  • Exception catching based on a non-literal (runtime) tuple could fail to match the exception.
  • Compile fix for CPython 3.7.0a2.

Signed-off-by: Pierre-Yves <pyu@riseup.net>

Test Plan
  • Unit tests executed
  • Build spyder & spyder3 against this package

Diff Detail

Repository
R585 cython
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

kyrios123 created this revision.Aug 17 2018, 4:13 PM
kyrios123 requested review of this revision.Aug 17 2018, 4:13 PM
kyrios123 edited the summary of this revision. (Show Details)Aug 17 2018, 4:14 PM
kyrios123 updated this revision to Diff 8933.Aug 17 2018, 4:15 PM

Update commented text

DataDrake accepted this revision.Aug 25 2018, 6:51 PM
DataDrake added a subscriber: DataDrake.

LGTM. Thanks!

This revision is now accepted and ready to land.Aug 25 2018, 6:51 PM
This revision was automatically updated to reflect the committed changes.