- Update to 1.2.0
- Correctly create the lpass man page with install-doc
Details
Details
- Reviewers
• sunnyflunk - Group Reviewers
Triage Team - Commits
- R1603:34259b5e15d7: properly install lpass man page, update to 1.2.0
- Installed locally and verified I can successfully load the man lpass entry
- Authenticated to new version via 2-factor, still works. Searching
and using content working as expected
Diff Detail
Diff Detail
- Repository
- R1603 lastpass-cli
- Branch
- master
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
| package.yml | ||
|---|---|---|
| 15 | Can we fix this properly. This will also include the man file setup : | %cmake build : | %make install : | %make_install install-doc | |
Comment Actions
@sunnyflunk - Thank you! For my own education, why did inlining the task alongside %make_install work when having it on a separate line did not? The (previous) behavior I saw was that the task didn't have root access to install the generated man page. Just curious, in case I run into this kind of thing again.
Comment Actions
LGTM thanks!
See this:
https://github.com/solus-project/ypkg/blob/master/ypkg2/rc.yml#L10
%make_install: make install DESTDIR="%installroot%"
%make install-doc: make -jx install-doc
Without DESTDIR, it ain't going to install it to the directory which gets made into the eopkg. Much how %make install wouldn't work