Page MenuHomeSolus

Enable python 3 bindings needed for onionshare T5181
AbandonedPublic

Authored by Devil505 on Aug 11 2018, 10:01 AM.
Tags
None
Referenced Files
F10845103: D3560.diff
Jun 10 2023, 11:03 PM
F10761924: D3560.id.diff
May 18 2023, 1:37 PM
F10755350: D3560.id8780.diff
May 16 2023, 11:38 PM
F10755345: D3560.id.diff
May 16 2023, 11:37 PM
F10737478: D3560.id8780.diff
May 13 2023, 4:22 AM
F10737141: D3560.diff
May 13 2023, 2:21 AM
F10725346: D3560.diff
May 8 2023, 7:10 AM
F10719868: D3560.id.diff
May 5 2023, 3:05 PM

Details

Reviewers
DataDrake
Group Reviewers
Triage Team
Test Plan

python 3 bindings present in the package

Diff Detail

Repository
R765 flask
Branch
master
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

I'd use D2778 because it's a more up-to-date version, it has the unit tests enabled but above all it has to binaries for python2 & 3 (this version overrides the python2 binary with the python3 one which will certainly cause issues with some python2 applications. You'll have to rested onionshare and see if something has to be changed for using the correct binary.

Devil505 retitled this revision from Enable pythong 3 bindings needed for onionshare T5181 to Enable python 3 bindings needed for onionshare T5181.Aug 15 2018, 10:09 AM

I'd use D2778 because it's a more up-to-date version, it has the unit tests enabled but above all it has to binaries for python2 & 3 (this version overrides the python2 binary with the python3 one which will certainly cause issues with some python2 applications. You'll have to rested onionshare and see if something has to be changed for using the correct binary.

I didn't see this diff, I'll build it and install it to check if onionshare still works with it.

You can close this diff, D2778 is clearly better !

DataDrake added a subscriber: DataDrake.

Stack please

This revision now requires changes to proceed.Aug 23 2018, 11:27 AM