Page MenuHomeSolus

Enable python 3 bindings needed for onionshare T5181
AbandonedPublic

Authored by Devil505 on Aug 11 2018, 10:01 AM.

Details

Reviewers
DataDrake
Group Reviewers
Triage Team
Test Plan

python 3 bindings present in the package

Diff Detail

Repository
R765 flask
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Devil505 created this revision.Aug 11 2018, 10:01 AM
Devil505 requested review of this revision.Aug 11 2018, 10:01 AM

I'd use D2778 because it's a more up-to-date version, it has the unit tests enabled but above all it has to binaries for python2 & 3 (this version overrides the python2 binary with the python3 one which will certainly cause issues with some python2 applications. You'll have to rested onionshare and see if something has to be changed for using the correct binary.

Devil505 retitled this revision from Enable pythong 3 bindings needed for onionshare T5181 to Enable python 3 bindings needed for onionshare T5181.Aug 15 2018, 10:09 AM

I'd use D2778 because it's a more up-to-date version, it has the unit tests enabled but above all it has to binaries for python2 & 3 (this version overrides the python2 binary with the python3 one which will certainly cause issues with some python2 applications. You'll have to rested onionshare and see if something has to be changed for using the correct binary.

I didn't see this diff, I'll build it and install it to check if onionshare still works with it.

You can close this diff, D2778 is clearly better !

DataDrake requested changes to this revision.Aug 23 2018, 11:27 AM
DataDrake added a subscriber: DataDrake.

Stack please

This revision now requires changes to proceed.Aug 23 2018, 11:27 AM