Page MenuHomeSolus
Differential D3518

libnetfilter_queue 1.0.3
ClosedPublic
Actions

Authored by czb on Aug 5 2018, 8:37 PM.
Tags
None
Referenced Files
F11004657: D3518.diff
Tue, Aug 1, 2:56 AM
F10993408: D3518.diff
Tue, Jul 25, 5:01 PM
F10989748: D3518.id8644.diff
Mon, Jul 24, 5:07 PM
F10920020: D3518.id.diff
Jul 9 2023, 5:26 AM
F10873181: D3518.id8726.diff
Jun 19 2023, 9:02 AM
F10864267: D3518.diff
Jun 17 2023, 7:13 AM
F10856677: D3518.id8726.diff
Jun 14 2023, 10:37 PM
F10841589: D3518.id8726.diff
Jun 10 2023, 7:59 AM
View All 23 Files
Subscribers
DataDrake

Details

Reviewers
DataDrake
Group Reviewers
Triage Team
Commits
R4417:92f7b1131b91: libnetfilter_queue 1.0.3
Summary

libnetfilter_queue submission, needed for T5036.

Test Plan
  1. Installing package libnetfilter_queue-devel.
  2. Installing python package NetfilterQueue.

Diff Detail

Branch
master
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

czb created this revision.Aug 5 2018, 8:37 PM
Herald added a reviewer: Triage Team. · View Herald TranscriptAug 5 2018, 8:37 PM
czb requested review of this revision.Aug 5 2018, 8:37 PM
DataDrake removed a task: T5036: NetfilterQueue.Aug 6 2018, 11:57 AM
DataDrake edited the summary of this revision. (Show Details)
DataDrake added a subscriber: DataDrake.

To be clear, this doesn't resolve T5036 as it only provides a library, not the python wrapper.

DataDrake accepted this revision.Aug 6 2018, 11:59 AM

LGTM. Thanks!

This revision is now accepted and ready to land.Aug 6 2018, 11:59 AM
czb added a comment.Aug 6 2018, 1:08 PM

What I meant when I submitted T5036 is that pip installation of NetfilterQueue in Solus was failing because of missing dependencies - libnetfilter_queue-devel, and now it works. I don't think we need to package NetfilterQueue separately if it's already available via pip.

DataDrake added a comment.Aug 6 2018, 2:08 PM

@czb I'd still like to have it in the repo since I'm sure something else will need it.

DataDrake requested changes to this revision.Aug 6 2018, 11:19 PM

My bad. Can you change the name to libnetfilter-queue? Thanks.

This revision now requires changes to proceed.Aug 6 2018, 11:19 PM
czb updated this revision to Diff 8726.Aug 7 2018, 5:22 PM

Change name from libnetfilter_queue to libnetfilter-queue.

DataDrake accepted this revision.Aug 11 2018, 2:24 PM

LGTM. Thanks!

This revision is now accepted and ready to land.Aug 11 2018, 2:24 PM
Closed by commit R4417:92f7b1131b91: libnetfilter_queue 1.0.3 (authored by czb, committed by DataDrake). · Explain WhyAug 11 2018, 2:24 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
1 line
78 lines
3 lines
21 lines
62 lines

Diff 8726

View Options

Makefile

Loading...
View Options

abi_symbols

Loading...
View Options

abi_used_libs

Loading...
View Options

package.yml

Loading...
View Options

pspec_x86_64.xml

Loading...
Copyright © 2015-2021 Solus Project. The Solus logo is Copyright © 2016-2021 Solus Project. All Rights Reserved.