Page MenuHomeSolus

libnetfilter_queue 1.0.3
ClosedPublic

Authored by czb on Aug 5 2018, 8:37 PM.

Details

Summary

libnetfilter_queue submission, needed for T5036.

Test Plan
  1. Installing package libnetfilter_queue-devel.
  2. Installing python package NetfilterQueue.

Diff Detail

Repository
R4417 libnetfilter-queue
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
czb created this revision.Aug 5 2018, 8:37 PM
czb requested review of this revision.Aug 5 2018, 8:37 PM
DataDrake edited the summary of this revision. (Show Details)
DataDrake added a subscriber: DataDrake.

To be clear, this doesn't resolve T5036 as it only provides a library, not the python wrapper.

DataDrake accepted this revision.Aug 6 2018, 11:59 AM

LGTM. Thanks!

This revision is now accepted and ready to land.Aug 6 2018, 11:59 AM
czb added a comment.Aug 6 2018, 1:08 PM

What I meant when I submitted T5036 is that pip installation of NetfilterQueue in Solus was failing because of missing dependencies - libnetfilter_queue-devel, and now it works. I don't think we need to package NetfilterQueue separately if it's already available via pip.

@czb I'd still like to have it in the repo since I'm sure something else will need it.

DataDrake requested changes to this revision.Aug 6 2018, 11:19 PM

My bad. Can you change the name to libnetfilter-queue? Thanks.

This revision now requires changes to proceed.Aug 6 2018, 11:19 PM
czb updated this revision to Diff 8726.Aug 7 2018, 5:22 PM

Change name from libnetfilter_queue to libnetfilter-queue.

DataDrake accepted this revision.Aug 11 2018, 2:24 PM

LGTM. Thanks!

This revision is now accepted and ready to land.Aug 11 2018, 2:24 PM
This revision was automatically updated to reflect the committed changes.