Differential D3518

libnetfilter_queue 1.0.3
ClosedPublic
Actions

Authored by czb on Aug 5 2018, 8:37 PM.

Details

Reviewers

DataDrake

Group Reviewers

Triage Team

Commits

R4417:92f7b1131b91: libnetfilter_queue 1.0.3

Summary

libnetfilter_queue submission, needed for T5036.

Test Plan

Installing package libnetfilter_queue-devel.
Installing python package NetfilterQueue.

Diff Detail

Repository

R4417 libnetfilter-queue

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

czb created this revision.Aug 5 2018, 8:37 PM

Herald added a reviewer: Triage Team. · View Herald TranscriptAug 5 2018, 8:37 PM

czb requested review of this revision.Aug 5 2018, 8:37 PM

To be clear, this doesn't resolve T5036 as it only provides a library, not the python wrapper.

LGTM. Thanks!

This revision is now accepted and ready to land.Aug 6 2018, 11:59 AM

What I meant when I submitted T5036 is that pip installation of NetfilterQueue in Solus was failing because of missing dependencies - libnetfilter_queue-devel, and now it works. I don't think we need to package NetfilterQueue separately if it's already available via pip.

@czb I'd still like to have it in the repo since I'm sure something else will need it.

My bad. Can you change the name to libnetfilter-queue? Thanks.

This revision now requires changes to proceed.Aug 6 2018, 11:19 PM

Change name from libnetfilter_queue to libnetfilter-queue.

LGTM. Thanks!

This revision is now accepted and ready to land.Aug 11 2018, 2:24 PM

Closed by commit R4417:92f7b1131b91: libnetfilter_queue 1.0.3 (authored by czb, committed by DataDrake). · Explain WhyAug 11 2018, 2:24 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

		Path
A	M	Makefile (1 line)
A	M	abi_symbols (78 lines)
A	M	abi_used_libs (3 lines)
A	M	package.yml (21 lines)
A	M	pspec_x86_64.xml (62 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	8644	4b825dc		Aug 5 2018, 8:37 PM	★	★
Diff 2	8726	4b825dc	Change name from libnetfilter_queue to libnetfilter-queue.	Aug 7 2018, 5:22 PM	★	★
Diff 3	8811	f74748b	R4417:92f7b1131b918947c834765e92b88cf3b7556541	Aug 11 2018, 2:24 PM	★	★