Page MenuHomeSolus

Update to 0.1.5
ClosedPublic

Authored by cunidev on Aug 2 2018, 11:34 AM.

Details

Summary

Updated Gestures to version 0.1.5

Changelog:

  • UI redesign
  • Implemented python-setuptools, appdata
  • Minor bugfixes
Test Plan

Installed Gestures both manually and with generated .eopkg file, created some gestures, then triggered, edited and removed them. All this app should do basically...

Diff Detail

Repository
R4326 gestures
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

cunidev created this revision.Aug 2 2018, 11:34 AM
cunidev requested review of this revision.Aug 2 2018, 11:34 AM
cunidev updated this revision to Diff 8561.Aug 2 2018, 11:37 AM

corrected release number typo

JoshStrobl requested changes to this revision.Aug 2 2018, 1:53 PM
JoshStrobl added a subscriber: JoshStrobl.

Needs a summary and test plan.

This revision now requires changes to proceed.Aug 2 2018, 1:53 PM
cunidev edited the summary of this revision. (Show Details)Aug 2 2018, 6:43 PM
cunidev edited the test plan for this revision. (Show Details)
cunidev edited the test plan for this revision. (Show Details)

I've edited the revision, thanks for the quick reply.

JoshStrobl accepted this revision.Aug 2 2018, 6:58 PM

Thanks for the summary and test plan, LGTM!

This revision is now accepted and ready to land.Aug 2 2018, 6:58 PM
JoshStrobl requested changes to this revision.Aug 2 2018, 6:59 PM

Correction, your commit is against a master branch this is not ours. Please ensure your patch is being applied on top of R4326

This revision now requires changes to proceed.Aug 2 2018, 6:59 PM

Oh, sorry. Just --update R4326 with the same contents, right?

No, you need to clone the repo then apply your changes on top of it, and then run arc diff --update D3478

I see, thanks. Sorry, I'm pretty new to packaging -.-

cunidev updated this revision to Diff 8578.EditedAug 3 2018, 1:21 PM
cunidev edited the summary of this revision. (Show Details)

Update to 0.1.5
(should now be based on the right repo)

@JoshStrobl is everything OK now? (thanks for the work on budgie btw)

JoshStrobl accepted this revision.Aug 7 2018, 12:20 AM
This revision is now accepted and ready to land.Aug 7 2018, 12:20 AM
This revision was automatically updated to reflect the committed changes.