Page MenuHomeSolus

Initial commit of python2-pylint
ClosedPublic

Authored by EP01 on Aug 1 2018, 10:59 AM.

Details

Summary

Python 2 LTS version of pylint for use with spyder since python2 support has been dropped in versions >=2.0.

Test Plan

Test with spyder.

Diff Detail

Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

EP01 created this revision.Aug 1 2018, 10:59 AM
EP01 requested review of this revision.Aug 1 2018, 10:59 AM
sunnyflunk requested changes to this revision.Aug 1 2018, 11:22 AM
sunnyflunk added a subscriber: sunnyflunk.

Blocking this till we discuss per D3348

This revision now requires changes to proceed.Aug 1 2018, 11:22 AM
EP01 added a comment.Aug 1 2018, 11:34 AM

@sunnyflunk I'm just putting all the work in place for when the discussion has been had. Will let you know when I'm done in this area and I can explain what I'm proposing.

In D3470#55324, @EP01 wrote:

@sunnyflunk I'm just putting all the work in place for when the discussion has been had. Will let you know when I'm done in this area and I can explain what I'm proposing.

Actually "Work in progress" stuffs are not accepted anymore as it generates useless noise for the triage team. They ask to commit the patches only when full stuff is ready and tested.

Now to add my 2 cents to this discussion

  • As far as I know there are currently no packages that require pylint 2.x in the repository and pylint 1.9 will still receive bugfixes until 2020 (end of python2 support), so personally I don't see any reason for updating pylint to 2.x
  • Solus has no python2- prefixed packages only a few python3- prefixed packages that are exceptions.
EP01 added a comment.EditedAug 1 2018, 12:25 PM

@kyrios123 It's not a WIP, I've been testing this locally for a while, just rebuilding and submitting atm. As for pylint 2, you are correct that no packages need it right now. However the work to separate the packages will be mandatory at some point, and it's nice for people who use pylint as a stand-alone package to have the latest features, so might as well do it now.

About the naming thing, do you have a suggestion for an alternative name?

In D3470#55347, @EP01 wrote:

However the work to separate the packages will be mandatory at some point

Who said that ?

EP01 added a comment.Aug 1 2018, 12:34 PM

@kyrios123 Nobody said it, but I'm assuming that either spyder or some other package will require it in the next 18 months, or, more likely, people will request the new features. The same treatment will be required for many Python packages in the short-term. It doesn't do any harm, anyway, this package can be deleted when we drop Python 2.

In D3470#55357, @EP01 wrote:

@kyrios123 Nobody said it, but I'm assuming that either spyder or some other package will require it in the next 18 months, or, more likely, people will request the new features. The same treatment will be required for many Python packages in the short-term. It doesn't do any harm, anyway, this package can be deleted when we drop Python 2.

What are the percentage of chances that a new package that requires pylint as a mandatory dependency and that does not support pylint 1.9.x is added in the repository before python2 reaches EOL?
And are you sure that spyder3 will stop working with pylint 1.9.x by then?

Wouldn't it be easier/wiser to simply keep on using 1.9.x until we start deprecating python2 packages (and thus spyder) instead of creating new packages that are already doomed to be withdrawn ?

EP01 added a comment.Aug 1 2018, 1:19 PM

@kyrios123 I think it's spyder version 4 that will drop python2 and possibly require a newer pylint. Also, remember that this is a stand-alone package, and those users are not going to be happy if they are stuck on LTS for 18 months. It doesn't matter either way, it's done now. It's up to the triage team if they wish to accept it.

@sunnyflunk This is ready to be merged. I've split pylint and asteroid into python2 and python3 packages for LTS of python2, and updated any references. I know the name of this particular package does not conform to the usual standards, however I was unable to come up with a suitable alternative. Please merge all items in the stack in one go to ensure compatibility.

EP01 requested review of this revision.Aug 1 2018, 1:19 PM
sunnyflunk requested changes to this revision.Aug 2 2018, 5:13 AM

Please don't change the status until this has been discussed (the alternative is to abandon so it isn't landed accidentally).

This revision now requires changes to proceed.Aug 2 2018, 5:13 AM
DataDrake accepted this revision.Aug 25 2018, 8:05 PM
DataDrake added a subscriber: DataDrake.

LGTM. Thanks!

This revision was not accepted when it landed; it landed in state Needs Revision.Aug 25 2018, 8:06 PM
Closed by commit R4472:0aa215de4018: Initial commit of python2-pylint (authored by EP01, committed by DataDrake). · Explain Why
This revision was automatically updated to reflect the committed changes.