Details
Details
- Reviewers
• sunnyflunk - Group Reviewers
Triage Team - Maniphest Tasks
- T5656: Lolcat
- Commits
- R4389:be5d42fa1339: Initial release of lolcat
Installed, piped some commands through it to watch the output with colour.
Diff Detail
Diff Detail
- Repository
- R4389 lolcat
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
Note I'll just put the comment here, but you have pushed these backwards. Phab can automatically stack the commits to provide a sane order, but they should be pushed in the order they are needed.
For this case you would push the ruby-* packages first, then you can put Depends on D3462 D3463 D3464 in this commit message and it will create a stack order for us to merge them in (i.e. merge those patches prior to pushing this one as it won't work without them).
In the other packages you can reference the task rather than this patch (since it wouldn't exist yet).
| package.yml | ||
|---|---|---|
| 15 | Fairly sure m comes before p xD (also in rundeps) | |
| 18 | This won't be needed if the others have rundeps on it. | |