Page MenuHomeSolus

Initial release of lolcat
ClosedPublic

Authored by stigarn on Jul 31 2018, 4:46 PM.
Tags
None
Referenced Files
F11012071: D3461.diff
Fri, Aug 4, 12:01 AM
F10986852: D3461.id8554.diff
Mon, Jul 24, 3:07 AM
F10969288: D3461.diff
Thu, Jul 20, 9:39 PM
F10968802: D3461.id8559.diff
Thu, Jul 20, 7:40 PM
F10968787: D3461.id8523.diff
Thu, Jul 20, 7:37 PM
F10896131: D3461.id8559.diff
Jul 1 2023, 10:13 PM
F10836069: D3461.id.diff
Jun 8 2023, 10:03 AM
F10735207: D3461.diff
May 12 2023, 12:05 PM
Subscribers

Details

Summary

Initial release of lolcat, solves T5656 Depends on D3462 D3463 D3464

Test Plan

Installed, piped some commands through it to watch the output with colour.

Diff Detail

Repository
R4389 lolcat
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

sunnyflunk added a subscriber: sunnyflunk.

Note I'll just put the comment here, but you have pushed these backwards. Phab can automatically stack the commits to provide a sane order, but they should be pushed in the order they are needed.

For this case you would push the ruby-* packages first, then you can put Depends on D3462 D3463 D3464 in this commit message and it will create a stack order for us to merge them in (i.e. merge those patches prior to pushing this one as it won't work without them).

In the other packages you can reference the task rather than this patch (since it wouldn't exist yet).

package.yml
15

Fairly sure m comes before p xD (also in rundeps)

18

This won't be needed if the others have rundeps on it.

This revision now requires changes to proceed.Jul 31 2018, 11:55 PM
This revision is now accepted and ready to land.Aug 2 2018, 3:49 AM
This revision was automatically updated to reflect the committed changes.