Page MenuHomeSolus

Initial commit of xdebug
ClosedPublic

Authored by der_eismann on Jun 6 2017, 9:53 AM.
Tags
None
Referenced Files
F11011328: D340.id1381.diff
Thu, Aug 3, 1:51 PM
F10994714: D340.id698.diff
Wed, Jul 26, 12:14 AM
F10993422: D340.id3904.diff
Tue, Jul 25, 5:04 PM
F10987045: D340.id1381.diff
Mon, Jul 24, 4:04 AM
F10985503: D340.id5692.diff
Sun, Jul 23, 9:46 PM
F10981382: D340.id.diff
Sun, Jul 23, 6:23 AM
F10967081: D340.id2918.diff
Thu, Jul 20, 7:43 AM
F10963923: D340.id5369.diff
Wed, Jul 19, 7:40 AM

Details

Reviewers
DataDrake
Group Reviewers
Triage Team
Maniphest Tasks
T2479: XDebug
Commits
R4058:56f020000635: Initial commit of xdebug
Summary

Initial commit of xdebug, fixes T2479.

Test Plan

Installed it and checked the extension via phpinfo();
Using visual studio code, run a debugging session with a simple php file.

Diff Detail

Repository
R4058 xdebug
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

DataDrake added a subscriber: DataDrake.

@der_eismann I need a stronger Test Plan than that. Not sure how to verify it works if I'm only checking that it is even loaded.

package.yml
8

Should be programming.tools

This revision now requires changes to proceed.Sep 2 2017, 6:15 PM
stobbsm added a subscriber: stobbsm.

Need this included soon, so I don't have to go through the hassle of configuring a docker xdebug session. Downloaded and tested that the package builds, and can be used for debug sessions when done.

der_eismann edited edge metadata.

Change package category to programming.tools

@ikey will need to review this as it's a custom license based on https://spdx.org/licenses/PHP-3.0.html

@ikey, do you think you have time to review the license soon?

I don't see a reason to be confused about the license.

package.yml
7

Let's change this to Xdebug-License-1.01

Otherwise, it's legally identical to the PHP 3.0 license. It just makes it so that the the author has full control over the use of the trademark Xdebug and any future changes to the license.

Change license to Xdebug-License-1.01

Changed license. Good now?

This revision is now accepted and ready to land.Feb 24 2018, 7:32 PM
This revision was automatically updated to reflect the committed changes.