Page MenuHomeSolus
Differential D3389

Initial release of coffee
ClosedPublic
Actions

Authored by Girtablulu on Jul 24 2018, 12:15 AM.
Tags
None
Referenced Files
F11022305: D3389.diff
Mon, Aug 7, 11:02 PM
F10993660: D3389.id8385.diff
Tue, Jul 25, 6:30 PM
F10988387: D3389.id8453.diff
Mon, Jul 24, 10:30 AM
F10981634: D3389.id8478.diff
Sun, Jul 23, 7:18 AM
F10976127: D3389.id8365.diff
Sat, Jul 22, 7:53 AM
F10975092: D3389.id8366.diff
Sat, Jul 22, 3:42 AM
F10969600: D3389.diff
Thu, Jul 20, 10:57 PM
F10877013: D3389.id8453.diff
Jun 20 2023, 3:07 PM
View All 10 Files
Subscribers
DataDrake
JoshStrobl

Details

Reviewers
DataDrake
JoshStrobl
Group Reviewers
Triage Team
Maniphest Tasks
T6166: coffee
Commits
R4377:152abaf007d9: Initial release of coffee
Summary

Initial release of coffee
Resolves T6166

Test Plan

Installed it and enjoyed some news with coffee

Diff Detail

Repository
R4377 coffee
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Girtablulu created this revision.Jul 24 2018, 12:15 AM
Herald added a reviewer: Triage Team. · View Herald TranscriptJul 24 2018, 12:15 AM
Girtablulu requested review of this revision.Jul 24 2018, 12:15 AM
Girtablulu edited the summary of this revision. (Show Details)Jul 24 2018, 12:16 AM
Girtablulu added a task: T6166: coffee.
Girtablulu updated this revision to Diff 8366.Jul 24 2018, 12:21 AM

Fixed builddeps layout

DataDrake requested changes to this revision.Jul 25 2018, 11:27 AM
DataDrake added a subscriber: DataDrake.
DataDrake added inline comments.
package.yml
15

Need to dedup your deps. Anything that's a dependency of another thing in this list isn't needed.

This revision now requires changes to proceed.Jul 25 2018, 11:27 AM
Girtablulu updated this revision to Diff 8385.Jul 25 2018, 11:41 AM

Removed not needed builddep

DataDrake requested changes to this revision.Jul 25 2018, 11:45 AM

There are still more, I just pointed out the one as an example.

This revision now requires changes to proceed.Jul 25 2018, 11:45 AM
Girtablulu updated this revision to Diff 8396.Jul 25 2018, 2:04 PM

this time for real, removed all none needed builddeps

JoshStrobl requested changes to this revision.Jul 27 2018, 9:54 AM
JoshStrobl added a subscriber: JoshStrobl.
JoshStrobl added inline comments.
package.yml
15

Not needed. It's a builddep of libwebkit-gtk-devel

This revision now requires changes to proceed.Jul 27 2018, 9:54 AM
Girtablulu updated this revision to Diff 8453.Jul 29 2018, 11:42 AM

All unneeded should be gone now

DataDrake accepted this revision.Jul 30 2018, 1:15 AM

LGTM. Thanks!

This revision was not accepted when it landed; it landed in state Needs Review.Jul 30 2018, 1:15 AM
Closed by commit R4377:152abaf007d9: Initial release of coffee (authored by Girtablulu, committed by DataDrake). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
1 line
13 lines
23 lines
43 lines

Diff 8478

View Options

Makefile

Loading...
View Options

abi_used_libs

Loading...
View Options

package.yml

Loading...
View Options

pspec_x86_64.xml

Loading...
Copyright © 2015-2021 Solus Project. The Solus logo is Copyright © 2016-2021 Solus Project. All Rights Reserved.