Page MenuHomeSolus

Fixed Brave Sync
ClosedPublic

Authored by alecbcs on Jul 23 2018, 6:35 PM.
Tags
None
Referenced Files
F11068355: D3384.id8359.diff
Fri, Aug 11, 9:43 PM
F11068354: D3384.id8358.diff
Fri, Aug 11, 9:43 PM
F11068353: D3384.id.diff
Fri, Aug 11, 9:43 PM
F11050650: D3384.diff
Thu, Aug 10, 7:13 PM
F11012217: D3384.id8359.diff
Fri, Aug 4, 1:33 AM
F10995622: D3384.id8359.diff
Wed, Jul 26, 5:51 AM
F10986230: D3384.id8358.diff
Mon, Jul 24, 12:21 AM
F10978564: D3384.id8359.diff
Sat, Jul 22, 7:45 PM
Subscribers
None

Details

Summary

Since the initial commit of Brave, the sync feature has been broken. With help from the Brave team, we figured out that the post install hook doesn't fire correctly when npm install is called. Therefore we must also call npm run postinstall to correctly install the sync module during the build process.

Test Plan

Tested this fix by generating a sync code in the browser menu and syncing Brave on my workstation and laptop. Everything functioned as expected.

Diff Detail

Repository
R4107 brave
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision is now accepted and ready to land.Jul 23 2018, 8:03 PM
kyrios123 retitled this revision from Fixed Bave Sync to Fixed Brave Sync.Jul 23 2018, 8:04 PM
This revision was automatically updated to reflect the committed changes.

Thanks for the last second fix, I didn't spot the typo :D