Page MenuHomeSolus

The inclusion of cli-visualiser fixes T6007
ClosedPublic

Authored by Snuggle on Jul 21 2018, 9:15 PM.

Details

Summary

Initial inclusion of cli-visualizer, an audio/music visualiser. T6007

Test Plan

Install the package and play some music to ensure it works correctly.

Diff Detail

Repository
R4378 cli-visualiser
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Snuggle created this revision.Jul 21 2018, 9:15 PM
Snuggle requested review of this revision.Jul 21 2018, 9:15 PM
Snuggle edited the summary of this revision. (Show Details)Jul 21 2018, 9:15 PM
Snuggle edited the summary of this revision. (Show Details)
Snuggle edited the test plan for this revision. (Show Details)Jul 21 2018, 11:04 PM
DataDrake requested changes to this revision.Jul 25 2018, 11:40 AM
DataDrake added a subscriber: DataDrake.
DataDrake added inline comments.
package.yml
2

nuke empty line

16

pkgconfig goes before other deps

19

Aren't these added automatically?

This revision now requires changes to proceed.Jul 25 2018, 11:40 AM
Snuggle updated this revision to Diff 8410.Jul 25 2018, 10:50 PM

Fixed package.yml

Snuggle marked 3 inline comments as done.Jul 25 2018, 10:51 PM

Oh woops, I didn't know build deps become run deps automatically.

DataDrake accepted this revision.Jul 30 2018, 1:21 AM

LGTM. Thanks!

This revision is now accepted and ready to land.Jul 30 2018, 1:21 AM
This revision was automatically updated to reflect the committed changes.