Page MenuHomeSolus

Update pylint to 2.0.1
ClosedPublic

Authored by EP01 on Jul 20 2018, 12:01 PM.

Details

Summary

Updated 'pylint' to the latest version 2.0.1.

Moved Python 2 support to a separate package.

Full changelog available here.

Test Plan

Installed and ran 'pylint --version' which reported the correct versions for
'pylint' and 'python-astroid'.
Tested linting several Python files with 'pylint' reporting the correct errors.

Diff Detail

Repository
R3714 pylint
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

debug created this revision.Jul 20 2018, 12:01 PM
debug requested review of this revision.Jul 20 2018, 12:01 PM
debug edited the summary of this revision. (Show Details)Jul 20 2018, 12:06 PM

Why did you remove python 2 support?

debug added a comment.EditedJul 25 2018, 11:23 AM

I dropped Python 2 support because pylint itself no longer supports Python 2. Here is an issue which was closed on the 9th of May saying that pylint 2.0 will be dropping support for Python 2. This is the same for python-astroid.

DataDrake accepted this revision.Jul 25 2018, 11:41 AM

Thanks for clarifying! LGTM.

This revision is now accepted and ready to land.Jul 25 2018, 11:41 AM
debug updated this revision to Diff 8388.Jul 25 2018, 11:58 AM

Update pylint to 2.0.1

debug edited the summary of this revision. (Show Details)Jul 25 2018, 11:59 AM
debug retitled this revision from Update pylint to 2.0 to Update pylint to 2.0.1.

I missed that you accepted this before I updated it to 2.0.1. Sorry it's only a minor change which fixes a crash.

Would this not mean having to drop spyder as a package since it no longer has python2 version of pylint

DataDrake requested changes to this revision.Jul 25 2018, 12:21 PM

Not asking you to do anything yet, but don't want this accidentally getting merged.

This revision now requires changes to proceed.Jul 25 2018, 12:21 PM
This comment was removed by debug.
debug added a comment.Jul 25 2018, 1:16 PM

I went ahead and built spyder and installed it and @sunnyflunk is correct. Updating pylint to 2.0 or above would mean that spyder will not work correctly. As far as I can see there could be three solutions to this. The first being to separate the pylint package into python2/3 versions keeping the python 2 version at 1.9 which IIRC will have python 2 support until 2020. The second solution would be to leave pylint at version 1.9 and see what the spyder developers do about the depreciation of python 2 support for pylint. The last would be to remove spyder but this seems a little extreme.

EP01 updated this revision to Diff 8545.Aug 1 2018, 11:53 AM
EP01 added a subscriber: EP01.

Reference new python3-astroid package.

EP01 commandeered this revision.Aug 1 2018, 12:18 PM
EP01 added a reviewer: debug.
EP01 edited the summary of this revision. (Show Details)
DataDrake accepted this revision.Aug 25 2018, 8:03 PM

LGTM. Thanks!

I'll fix the deps post merge

This revision is now accepted and ready to land.Aug 25 2018, 8:03 PM
This revision was automatically updated to reflect the committed changes.