Page MenuHomeSolus

Inclusion of python-fann2 which depends on D3180 and runtime dep of mycroft-core T4276
ClosedPublic

Authored by clivejo on Jul 17 2018, 10:17 PM.

Details

Summary

Inclusion of python-fann2 which depends on D3180 and runtime dep of mycroft-core T4276

Test Plan

install mycroft-core and use voice to control your PC

Diff Detail

Repository
R4343 python-fann2
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

clivejo created this revision.Jul 17 2018, 10:17 PM
clivejo requested review of this revision.Jul 17 2018, 10:17 PM
JoshStrobl requested changes to this revision.Jul 18 2018, 10:49 AM
JoshStrobl added a subscriber: JoshStrobl.
JoshStrobl added inline comments.
package.yml
16–17

Not needed, it already depends on libfann, as per the abi_used_libs indication: "libdoublefann.so.2"

This revision now requires changes to proceed.Jul 18 2018, 10:49 AM
clivejo updated this revision to Diff 8208.Jul 18 2018, 10:59 AM

Remove rundep on libfann, as per review

JoshStrobl accepted this revision.Jul 18 2018, 11:22 AM
This revision is now accepted and ready to land.Jul 18 2018, 11:22 AM
This revision was automatically updated to reflect the committed changes.