Page MenuHomeSolus
Differential D3283

The inclusion of pwned-checker fixes T6654
ClosedPublic
Actions

Authored by Devil505 on Jul 13 2018, 11:19 AM.
Tags
None
Referenced Files
F11073620: D3283.id8279.diff
Sat, Aug 12, 4:43 AM
F11073619: D3283.id8113.diff
Sat, Aug 12, 4:43 AM
F11073618: D3283.id8318.diff
Sat, Aug 12, 4:43 AM
F11055125: D3283.diff
Fri, Aug 11, 1:29 AM
F10926181: D3283.id.diff
Jul 10 2023, 11:08 AM
F10907260: D3283.id8318.diff
Jul 6 2023, 6:48 PM
F10833130: D3283.diff
Jun 6 2023, 3:32 PM
F10775136: D3283.id.diff
May 22 2023, 2:41 PM
View All 9 Files
Subscribers
DataDrake
kyrios123

Details

Reviewers
DataDrake
Group Reviewers
Triage Team
Maniphest Tasks
T6654: pwned-checker
Commits
R4350:84b039deaa33: The inclusion of pwned-checker fixes T6654
Test Plan

I've tested the app to check a password and an email.
Working fine.

Diff Detail

Repository
R4350 pwned-checker
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Devil505 created this revision.Jul 13 2018, 11:19 AM
Herald added a reviewer: Triage Team. · View Herald TranscriptJul 13 2018, 11:19 AM
Devil505 requested review of this revision.Jul 13 2018, 11:19 AM
Devil505 added a task: T6654: pwned-checker.Jul 13 2018, 11:19 AM
DataDrake requested changes to this revision.Jul 19 2018, 1:44 PM
DataDrake added a subscriber: DataDrake.

Needs a rebuild for missing abi_used_libs

This revision now requires changes to proceed.Jul 19 2018, 1:44 PM
Devil505 added a comment.Jul 19 2018, 5:38 PM
In D3283#53167, @DataDrake wrote:

Needs a rebuild for missing abi_used_libs

could you be more specific ?

kyrios123 added a subscriber: kyrios123.Jul 19 2018, 6:34 PM
In D3283#53310, @Devil505 wrote:
In D3283#53167, @DataDrake wrote:

Needs a rebuild for missing abi_used_libs

could you be more specific ?

The files abi* are missing the files are generated when you run make or make local from within the repository. If you call directly solbuild, then you have to also execute make abireport to generate the files.

Devil505 added a comment.Jul 19 2018, 7:04 PM
In D3283#53314, @kyrios123 wrote:
In D3283#53310, @Devil505 wrote:
In D3283#53167, @DataDrake wrote:

Needs a rebuild for missing abi_used_libs

could you be more specific ?

The files abi* are missing the files are generated when you run make or make local from within the repository. If you call directly solbuild, then you have to also execute make abireport to generate the files.

OK thanks :-)

Devil505 updated this revision to Diff 8279.Jul 19 2018, 7:10 PM

added abi_used_libs

Devil505 added a comment.Jul 19 2018, 7:11 PM

I hope it's good now, thanks @kyrios123 !

DataDrake accepted this revision.Jul 21 2018, 4:00 PM

LGTM. Thanks!

This revision is now accepted and ready to land.Jul 21 2018, 4:00 PM
Closed by commit R4350:84b039deaa33: The inclusion of pwned-checker fixes T6654 (authored by Devil505, committed by DataDrake). · Explain WhyJul 21 2018, 4:01 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
1 line
8 lines
23 lines
244 lines

Diff 8318

View Options

Makefile

Loading...
View Options

abi_used_libs

Loading...
View Options

package.yml

Loading...
View Options

pspec_x86_64.xml

Loading...
Copyright © 2015-2021 Solus Project. The Solus logo is Copyright © 2016-2021 Solus Project. All Rights Reserved.