Paths

Table of Contentst

Differential D3281

inclusion of magic-wormhole fixes T5978
ClosedPublic
Actions

Authored by Devil505 on Jul 12 2018, 3:29 PM.

Tags

None

Referenced Files

	F11055070: D3281.id.diff
	Fri, Aug 11, 1:25 AM

	F11055069: D3281.id8975.diff
	Fri, Aug 11, 1:25 AM

	F11055068: D3281.id8102.diff
	Fri, Aug 11, 1:25 AM

	F11038402: D3281.diff
	Wed, Aug 9, 10:38 PM

	F10989811: D3281.diff
	Mon, Jul 24, 5:25 PM

	F10774044: D3281.diff
	May 22 2023, 2:31 AM

	F10755432: D3281.diff
	May 16 2023, 11:56 PM

	F10693827: D3281.id.diff
	Apr 25 2023, 7:12 AM

Subscribers

Details

Reviewers

Group Reviewers

Maniphest Tasks

T5978: magic-wormhole

Commits

R4443:1b3e17401277: inclusion of magic-wormhole fixes T5978

Test Plan

Python 3 bindings of python-ipaddress is *NEEDED* to launch wormhole
I rebuild python-ipaddress with python 3 instead of 2 and wormhole can be normally launched
I spoke with kyrios about this. Normally ipaddress is supposed to already included in python>3.3.
We'll try to find a solution :)

Diff Detail

Repository

R4443 magic-wormhole

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Devil505 created this revision.Jul 12 2018, 3:29 PM

Herald added a reviewer: Triage Team. · View Herald TranscriptJul 12 2018, 3:29 PM

Devil505 requested review of this revision.Jul 12 2018, 3:29 PM

Devil505 added a task: T5978: magic-wormhole.Jul 12 2018, 3:31 PM

Devil505 added child revisions: D3280: python-txtorcon, depend for the inclusion of magic-wormhole, D3279: python-tqdm, depend for the inclusion of magic-wormhole, D3278: python-spake2, depend for the inclusion of magic-wormhole, D3277: python-pynacl, depend for the inclusion of magic-wormhole, D3275: python-hkdf, depend for the inclusion of magic-wormhole T5978, D3276: python-humanize, depend for the inclusion of magic-wormhole, D3274: python-autobahn, depend for the inclusion of magic-wormhole fixes T5978, D3273: python-txaio, depend for the inclusion of magic-wormhole fixes T5978.

Devil505 edited the test plan for this revision. (Show Details)

Devil505 added a subscriber: kyrios123.

FYI - I have opened an issue upstream.
A review of the runtime dependencies should be done once the issues have been solved.

Your stack is upside down.

This revision now requires changes to proceed.Jul 19 2018, 1:49 PM

In D3281#53190, @DataDrake wrote:

Your stack is upside down.

Any help is welcome

In D3281#53309, @Devil505 wrote:

In D3281#53190, @DataDrake wrote:

Your stack is upside down.

Any help is welcome

Basically you have to set the parent/child revision the other way around (the parents should be the childs). Look at the stack, you should read it from bottom to top.

Instead of editing the parent/child revisions from the web interface, it is much easier imo to use the keywords Depends on as explained on the help center. Just submit the dependencies first, so you get the differential number Dxxxx then you can add it in the summary the parent. Here is an example.

Devil505 removed child revisions: D3273: python-txaio, depend for the inclusion of magic-wormhole fixes T5978, D3274: python-autobahn, depend for the inclusion of magic-wormhole fixes T5978, D3276: python-humanize, depend for the inclusion of magic-wormhole, D3275: python-hkdf, depend for the inclusion of magic-wormhole T5978, D3277: python-pynacl, depend for the inclusion of magic-wormhole, D3278: python-spake2, depend for the inclusion of magic-wormhole, D3279: python-tqdm, depend for the inclusion of magic-wormhole, D3280: python-txtorcon, depend for the inclusion of magic-wormhole.Jul 28 2018, 6:33 PM

Devil505 added a parent revision: D3274: python-autobahn, depend for the inclusion of magic-wormhole fixes T5978.

Devil505 added a child revision: D3276: python-humanize, depend for the inclusion of magic-wormhole.

Devil505 added a child revision: D3277: python-pynacl, depend for the inclusion of magic-wormhole.

Devil505 added a child revision: D3278: python-spake2, depend for the inclusion of magic-wormhole.

Devil505 added a child revision: D3279: python-tqdm, depend for the inclusion of magic-wormhole.Jul 28 2018, 6:35 PM

Devil505 added a child revision: D3280: python-txtorcon, depend for the inclusion of magic-wormhole.

Devil505 added a child revision: D3275: python-hkdf, depend for the inclusion of magic-wormhole T5978.

Devil505 removed a child revision: D3275: python-hkdf, depend for the inclusion of magic-wormhole T5978.

Devil505 added a parent revision: D3275: python-hkdf, depend for the inclusion of magic-wormhole T5978.

Devil505 removed a child revision: D3280: python-txtorcon, depend for the inclusion of magic-wormhole.Jul 28 2018, 6:37 PM

Devil505 removed child revisions: D3279: python-tqdm, depend for the inclusion of magic-wormhole, D3278: python-spake2, depend for the inclusion of magic-wormhole, D3277: python-pynacl, depend for the inclusion of magic-wormhole, D3276: python-humanize, depend for the inclusion of magic-wormhole.

Devil505 removed a parent revision: D3274: python-autobahn, depend for the inclusion of magic-wormhole fixes T5978.

Devil505 removed a parent revision: D3275: python-hkdf, depend for the inclusion of magic-wormhole T5978.Jul 28 2018, 6:40 PM

Devil505 added child revisions: D3274: python-autobahn, depend for the inclusion of magic-wormhole fixes T5978, D3276: python-humanize, depend for the inclusion of magic-wormhole, D3280: python-txtorcon, depend for the inclusion of magic-wormhole, D3277: python-pynacl, depend for the inclusion of magic-wormhole, D3278: python-spake2, depend for the inclusion of magic-wormhole, D3279: python-tqdm, depend for the inclusion of magic-wormhole, D3275: python-hkdf, depend for the inclusion of magic-wormhole T5978.

Devil505 removed child revisions: D3275: python-hkdf, depend for the inclusion of magic-wormhole T5978, D3279: python-tqdm, depend for the inclusion of magic-wormhole, D3278: python-spake2, depend for the inclusion of magic-wormhole, D3277: python-pynacl, depend for the inclusion of magic-wormhole, D3280: python-txtorcon, depend for the inclusion of magic-wormhole, D3276: python-humanize, depend for the inclusion of magic-wormhole, D3274: python-autobahn, depend for the inclusion of magic-wormhole fixes T5978.

Devil505 added parent revisions: D3280: python-txtorcon, depend for the inclusion of magic-wormhole, D3278: python-spake2, depend for the inclusion of magic-wormhole, D3277: python-pynacl, depend for the inclusion of magic-wormhole, D3276: python-humanize, depend for the inclusion of magic-wormhole, D3274: python-autobahn, depend for the inclusion of magic-wormhole fixes T5978, D3275: python-hkdf, depend for the inclusion of magic-wormhole T5978, D3279: python-tqdm, depend for the inclusion of magic-wormhole.Jul 28 2018, 6:42 PM

LGTM. Thanks!

This revision is now accepted and ready to land.Aug 18 2018, 10:06 PM

Closed by commit R4443:1b3e17401277: inclusion of magic-wormhole fixes T5978 (authored by Devil505, committed by DataDrake). · Explain WhyAug 18 2018, 10:07 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

1 line

26 lines

pspec_x86_64.xml

168 lines

Diff 8975

Makefile

Loading...

package.yml

Loading...

pspec_x86_64.xml

Loading...