Differential D3280

python-txtorcon, depend for the inclusion of magic-wormhole
ClosedPublic
Actions

Authored by Devil505 on Jul 12 2018, 3:19 PM.

Tags

None

Referenced Files

	F11055077: D3280.id8972.diff
	Fri, Aug 11, 1:25 AM

	F11055076: D3280.id8101.diff
	Fri, Aug 11, 1:25 AM

	F11055075: D3280.id.diff
	Fri, Aug 11, 1:25 AM

	F11055074: D3280.id8125.diff
	Fri, Aug 11, 1:25 AM

	F11038404: D3280.diff
	Wed, Aug 9, 10:38 PM

	F11013270: D3280.diff
	Fri, Aug 4, 11:58 AM

	F10990085: D3280.diff
	Mon, Jul 24, 7:03 PM

	F10983609: D3280.diff
	Sun, Jul 23, 2:58 PM

View All 17 Files

Subscribers

Details

Reviewers

kyrios123
DataDrake

Group Reviewers

Maniphest Tasks

T5978: magic-wormhole

Commits

R4441:e768970fb34d: python-txtorcon, depend for the inclusion of magic-wormhole

Test Plan

needed to launch wormhole

Diff Detail

Repository

R4441 python-txtorcon

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Devil505 created this revision.Jul 12 2018, 3:19 PM

Herald added a reviewer: Triage Team. · View Herald TranscriptJul 12 2018, 3:19 PM

Devil505 requested review of this revision.Jul 12 2018, 3:19 PM

Devil505 added a parent revision: D3281: inclusion of magic-wormhole fixes T5978.Jul 12 2018, 3:31 PM

Devil505 added a task: T5978: magic-wormhole.

kyrios123 added a subscriber: kyrios123.Jul 13 2018, 4:59 PM

kyrios123 added inline comments.

package.yml
14	ipaddress is part of core python since version 3.3; the python-ipaddress package is a backport for older python (meaning python 2.7 in Solus), so it shouldn't appear here as this is a python3 build only. The txtocron doc says the same.

kyrios123 requested changes to this revision.Jul 13 2018, 4:59 PM

This revision now requires changes to proceed.Jul 13 2018, 4:59 PM

kyrios123 added inline comments.Jul 13 2018, 5:00 PM

pspec_x86_64.xml
6	This won't be accepted

fixing depends

Devil505 removed a parent revision: D3281: inclusion of magic-wormhole fixes T5978.Jul 28 2018, 6:33 PM

Devil505 added a parent revision: D3281: inclusion of magic-wormhole fixes T5978.Jul 28 2018, 6:35 PM

Devil505 removed a parent revision: D3281: inclusion of magic-wormhole fixes T5978.Jul 28 2018, 6:37 PM

Devil505 added a parent revision: D3281: inclusion of magic-wormhole fixes T5978.Jul 28 2018, 6:40 PM

Devil505 removed a parent revision: D3281: inclusion of magic-wormhole fixes T5978.

Devil505 added a child revision: D3281: inclusion of magic-wormhole fixes T5978.

LGTM. Thanks!

This revision was not accepted when it landed; it landed in state Needs Review.Aug 18 2018, 10:01 PM

Closed by commit R4441:e768970fb34d: python-txtorcon, depend for the inclusion of magic-wormhole (authored by Devil505, committed by DataDrake). · Explain Why

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

1 line

17 lines

pspec_x86_64.xml

171 lines

Diff 8972

Makefile

Loading...

package.yml

Loading...

pspec_x86_64.xml

Loading...