Page MenuHomeSolus

Update ruby-sass to 3.4.24
ClosedPublic

Authored by poltertec on Jun 4 2017, 11:12 AM.

Details

Summary

Update to 3.4.24. Depends on D327 & Depends on D326 since this release.

Changelog:

  • Elements without a namespace (such as div) are no longer unified with elements with the empty namespace (such as |div). This unification didn't match the results returned by is-superselector(), and was not guaranteed to be valid.
  • The Sass logger is now instantiated on a per-thread/per-fiber basis and can now be configured to output to any IO object. This can help services and processes that wrap Sass compilation reliably extract warnings in a concurrent environment.
  • Setting the numeric precision by assigning to Sass::Script::Value::Number.precision is now thread safe. To set for all threads, be sure to set the precision on the main thread.
  • Sass cache files will now be world and group writable if your umask allows it. Issue #1623
  • The supports(...) clause in @import statements now allows bare declarations as per the CSS specification. Issue #1967
  • Fix a bug where, under some circumstances, str-slice() would go to the end of the string even if $end-at was set.
  • Fix conversions between numbers with dpi, dpcm, and dppx units. Previously these conversions were inverted.
  • Support url()s containing quoted strings within unknown directives.
Test Plan

Tested while editing a gtk+ theme using the sass --watch command.
Changes were detected and committed as expected.

Diff Detail

Repository
R2836 ruby-sass
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

poltertec created this revision.Jun 4 2017, 11:12 AM
poltertec retitled this revision from Update to 3.4.24 Depends on ruby-redcarpet to Update to 3.4.24.Jun 4 2017, 11:42 AM
poltertec edited the summary of this revision. (Show Details)
poltertec retitled this revision from Update to 3.4.24 to Update ruby-sass to 3.4.24.Jun 4 2017, 12:07 PM
poltertec edited the test plan for this revision. (Show Details)Jun 4 2017, 12:28 PM
poltertec edited the summary of this revision. (Show Details)Jun 5 2017, 10:54 AM
poltertec edited the summary of this revision. (Show Details)Jun 5 2017, 10:56 AM
poltertec added a parent revision: D326: Update ruby-yard to 0.9.9.
JoshStrobl requested changes to this revision.Jun 6 2017, 2:10 PM
JoshStrobl added a subscriber: JoshStrobl.

Please provide a more comprehensive test case than "application runs normally". Thanks.

This revision now requires changes to proceed.Jun 6 2017, 2:10 PM
poltertec edited the test plan for this revision. (Show Details)Jun 6 2017, 10:54 PM

Some more info on the test case was added.

poltertec edited the test plan for this revision. (Show Details)Jun 6 2017, 10:56 PM
poltertec edited the summary of this revision. (Show Details)Jun 9 2017, 9:55 PM
poltertec edited the test plan for this revision. (Show Details)
poltertec updated this revision to Diff 776.Jun 9 2017, 10:12 PM
poltertec edited edge metadata.
poltertec edited the summary of this revision. (Show Details)
poltertec edited the test plan for this revision. (Show Details)

Update ruby-sass to 3.4.24

JoshStrobl accepted this revision.Jun 12 2017, 2:07 PM
This revision is now accepted and ready to land.Jun 12 2017, 2:07 PM
This revision was automatically updated to reflect the committed changes.