Paths

Table of Contentst

Differential D3277

python-pynacl, depend for the inclusion of magic-wormhole
ClosedPublic
Actions

Authored by Devil505 on Jul 12 2018, 3:12 PM.

Tags

None

Referenced Files

	F11055089: D3277.id8098.diff
	Fri, Aug 11, 1:26 AM

	F11055088: D3277.id8123.diff
	Fri, Aug 11, 1:26 AM

	F11055087: D3277.id8103.diff
	Fri, Aug 11, 1:26 AM

	F11055086: D3277.id8124.diff
	Fri, Aug 11, 1:26 AM

	F11055084: D3277.id8968.diff
	Fri, Aug 11, 1:26 AM

	F11055083: D3277.id.diff
	Fri, Aug 11, 1:26 AM

	F11038406: D3277.diff
	Wed, Aug 9, 10:39 PM

	F11022446: D3277.diff
	Tue, Aug 8, 12:49 AM

View All 19 Files

Subscribers

Details

Reviewers

kyrios123
DataDrake

Group Reviewers

Maniphest Tasks

T5978: magic-wormhole

Commits

R4437:d0290fb5caff: python-pynacl, depend for the inclusion of magic-wormhole

Test Plan

needed to launch wormhole

Diff Detail

Branch

master

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

Devil505 created this revision.Jul 12 2018, 3:12 PM

Herald added a reviewer: Triage Team. · View Herald TranscriptJul 12 2018, 3:12 PM

Devil505 requested review of this revision.Jul 12 2018, 3:12 PM

Devil505 added a parent revision: D3281: inclusion of magic-wormhole fixes T5978.Jul 12 2018, 3:31 PM

Devil505 added a task: T5978: magic-wormhole.

fixing xml file

This package misses dependencies, it does not even build.
According to what I see here, python-cffi, python-six and libsodium should be added as runtime dependencies.
You should also tell it to use the system libsodium with export SODIUM_INSTALL=system

This revision now requires changes to proceed.Jul 13 2018, 4:47 PM

fixing missing depends
libsodium install added

fixing license

Devil505 removed a parent revision: D3281: inclusion of magic-wormhole fixes T5978.Jul 28 2018, 6:33 PM

Devil505 added a parent revision: D3281: inclusion of magic-wormhole fixes T5978.

Devil505 removed a parent revision: D3281: inclusion of magic-wormhole fixes T5978.Jul 28 2018, 6:37 PM

Devil505 added a parent revision: D3281: inclusion of magic-wormhole fixes T5978.Jul 28 2018, 6:40 PM

Devil505 removed a parent revision: D3281: inclusion of magic-wormhole fixes T5978.

Devil505 added a child revision: D3281: inclusion of magic-wormhole fixes T5978.

LGTM. Thanks!

This revision was not accepted when it landed; it landed in state Needs Review.Aug 18 2018, 9:36 PM

Closed by commit R4437:d0290fb5caff: python-pynacl, depend for the inclusion of magic-wormhole (authored by Devil505, committed by DataDrake). · Explain Why

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

1 line

14 lines

pspec_x86_64.xml

92 lines

Diff 8098

Makefile

Loading...

package.yml

Loading...

pspec_x86_64.xml

Loading...