Page MenuHomeSolus

python-autobahn, depend for the inclusion of magic-wormhole fixes T5978
ClosedPublic

Authored by Devil505 on Jul 12 2018, 2:50 PM.
Tags
None
Referenced Files
F11055082: D3274.id8970.diff
Fri, Aug 11, 1:25 AM
F11055081: D3274.id.diff
Fri, Aug 11, 1:25 AM
F11055080: D3274.id8095.diff
Fri, Aug 11, 1:25 AM
F11055079: D3274.id8104.diff
Fri, Aug 11, 1:25 AM
F11055078: D3274.id8140.diff
Fri, Aug 11, 1:25 AM
F11038405: D3274.diff
Wed, Aug 9, 10:38 PM
F10997757: D3274.diff
Thu, Jul 27, 1:03 PM
F10994954: D3274.diff
Wed, Jul 26, 1:43 AM

Details

Test Plan

wormhome needed it to be launched

Diff Detail

Repository
R4439 python-autobahn
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

According to what I see the the setup.py, it seems this package misses dependencies.

added missing build & runtime depends

added missing build & runtime depends

The builddeps are requires only for the unit tests I guess since it builds fine without them ?

python-txaio is needed to build. Could you try ?

It builds without any build dependency.

It builds without any build dependency.

Unhandled Error
Traceback (most recent call last):
  File "setup.py", line 302, in <module>
    list(getPlugins(IPlugin))
  File "/usr/lib/python3.6/site-packages/twisted/plugin.py", line 213, in getPlugins
    allDropins = getCache(package)
--- <exception caught here> ---
  File "/usr/lib/python3.6/site-packages/twisted/plugin.py", line 171, in getCache
    provider = pluginModule.load()
  File "/usr/lib/python3.6/site-packages/twisted/python/modules.py", line 392, in load
    return self.pathEntry.pythonPath.moduleLoader(self.name)
  File "/usr/lib/python3.6/site-packages/twisted/python/reflect.py", line 308, in namedAny
    topLevelPackage = _importAndCheckStack(trialname)
  File "/usr/lib/python3.6/site-packages/twisted/python/reflect.py", line 255, in _importAndCheckStack
    reraise(excValue, excTraceback)
  File "/usr/lib/python3.6/site-packages/twisted/python/compat.py", line 463, in reraise
    raise exception.with_traceback(traceback)
  File "/home/build/YPKG/root/python-autobahn/build/py3build/twisted/plugins/autobahn_endpoints.py", line 46, in <module>
    from autobahn.twisted.websocket import WrappingWebSocketServerFactory, \
  File "/home/build/YPKG/root/python-autobahn/build/py3build/autobahn/twisted/__init__.py", line 41, in <module>
    from autobahn.twisted.choosereactor import install_reactor
  File "/home/build/YPKG/root/python-autobahn/build/py3build/autobahn/twisted/choosereactor.py", line 32, in <module>
    import txaio
builtins.ModuleNotFoundError: No module named 'txaio'

It builds without any build dependency.

Unhandled Error
Traceback (most recent call last):
  File "setup.py", line 302, in <module>
    list(getPlugins(IPlugin))
  File "/usr/lib/python3.6/site-packages/twisted/plugin.py", line 213, in getPlugins
    allDropins = getCache(package)
--- <exception caught here> ---
  File "/usr/lib/python3.6/site-packages/twisted/plugin.py", line 171, in getCache
    provider = pluginModule.load()
  File "/usr/lib/python3.6/site-packages/twisted/python/modules.py", line 392, in load
    return self.pathEntry.pythonPath.moduleLoader(self.name)
  File "/usr/lib/python3.6/site-packages/twisted/python/reflect.py", line 308, in namedAny
    topLevelPackage = _importAndCheckStack(trialname)
  File "/usr/lib/python3.6/site-packages/twisted/python/reflect.py", line 255, in _importAndCheckStack
    reraise(excValue, excTraceback)
  File "/usr/lib/python3.6/site-packages/twisted/python/compat.py", line 463, in reraise
    raise exception.with_traceback(traceback)
  File "/home/build/YPKG/root/python-autobahn/build/py3build/twisted/plugins/autobahn_endpoints.py", line 46, in <module>
    from autobahn.twisted.websocket import WrappingWebSocketServerFactory, \
  File "/home/build/YPKG/root/python-autobahn/build/py3build/autobahn/twisted/__init__.py", line 41, in <module>
    from autobahn.twisted.choosereactor import install_reactor
  File "/home/build/YPKG/root/python-autobahn/build/py3build/autobahn/twisted/choosereactor.py", line 32, in <module>
    import txaio
builtins.ModuleNotFoundError: No module named 'txaio'

This is because you are now building the package on top of twisted while in the original diff you submitted you built it on top of asyncio . Different frameworks -> different per-requisites. (installation manual)

This revision is now accepted and ready to land.Aug 18 2018, 9:57 PM
This revision was automatically updated to reflect the committed changes.