Differential D319

Initial version of cantata
ClosedPublic
Actions

Authored by kyrios123 on Jun 3 2017, 4:17 PM.

Details

Reviewers

JoshStrobl

Group Reviewers

Triage Team

Maniphest Tasks

T3373: cantata - Qt5 mpd client

Commits

R3514:f9e4f518b7c7: Initial version of cantata

Summary

See offical release notes

Fixed in this release:

Fix 'Scroll to current track' in table style play queue if track number column is hidden.
Fix possibly missing save play queue icon.
Fix listing of CUE files.
Fix compilation on some systems.
Fix playback of AudioCDs
Fix incorrect AudioCD cover
Fix Qt5 gcc5 compilation.
Fix wrong/missing ratings in toolbar.
Fix compilation with Qt5.7
Fix drag'n'drop of non-loaded playlists.
Fix AudioCD playback when MPD's curl is using IPv6
Fix current track display when chaging from one track with no meta-data to another with no meta-data.

Signed-off-by: Pierre-Yves <pyu@riseup.net>

Test Plan

Fixes T3373

Install, Launch application, import a podcast.

Diff Detail

Repository

R3514 cantata

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kyrios123 created this revision.Jun 3 2017, 4:17 PM

Herald added a reviewer: Triage Team. · View Herald TranscriptJun 3 2017, 4:17 PM

remove .eopkg

remove .eopkg

I SAW NOTHING

In D319#4455, @ikey wrote:

I SAW NOTHING

Ouf! I'd have been ashamed if somebody noticed !!!

Fixes should go in summary and a valid test plan (and thus testing) be provided.

This revision now requires changes to proceed.Jun 6 2017, 2:15 PM

In D319#4767, @JoshStrobl wrote:

Fixes should go in summary and a valid test plan (and thus testing) be provided.

Oh I didn't know it was required to detail the fixes when a new package is added in the repository.
I'll detail this, sorry.

I'll add a test plan but honestly, it's very limited. I just insured the application starts normally and doesn't crash/freeze when I click a few buttons.
It would be nice in some cases to have the possibility to provide the packages and eventually some dependencies if necessary to the person who created the task so he/she could perform deeper tests and therefore increase the quality. Those special cases could be some new packages inclusion, when there are some complex problems or when specific hardware is necessary.

kyrios123 edited the summary of this revision. (Show Details)Jun 6 2017, 7:49 PM

kyrios123 edited the test plan for this revision. (Show Details)

kyrios123 added a project: Patch Submission.

kyrios123 requested review of this revision.Jun 7 2017, 8:00 PM

kyrios123 edited edge metadata.

JoshStrobl accepted this revision.Jun 12 2017, 2:06 PM

This revision is now accepted and ready to land.Jun 12 2017, 2:06 PM

Closed by commit R3514:f9e4f518b7c7: Initial version of cantata (authored by kyrios123, committed by JoshStrobl). · Explain WhyJun 12 2017, 2:44 PM

This revision was automatically updated to reflect the committed changes.