Differential D3191

NM dnsmasq isolation for wifi-ap
ClosedPublic
Actions

Authored by • Psi-Jack on Jun 30 2018, 4:26 PM.

Details

Reviewers

• sunnyflunk

Group Reviewers

Triage Team

Maniphest Tasks

T84: Hotspot not working

Commits

R2155:ab0f2449b2f4: NM dnsmasq isolation for wifi-ap
R2155:ce24e9052f43: NM dnsmasq isolation for wifi-ap

Summary

Fixes T84 with D3190. This isolates NM to not use the system-wide
dnsmasq.conf and sets the dhcp-leasefile to NetworkManager's
NMSTATEDIR where it belongs in this instance.

Patch provided here has also been submitted and accepted upstream.

Side note: Though 1.12.0 should be binary compatible with previous
versions, Steam stopped working when testing 1.12.0, so I've kept
this back to 1.10.x series for the time being.

Test Plan

Using nmcli or nm-applet to test hotspot ap capability:

nmcli con add type wifi ifname wlan0 con-name Hostspot autoconnect yes ssid Hostspot
nmcli con modify Hostspot 802-11-wireless.mode ap 802-11-wireless.band bg ipv4.method shared
nmcli con modify Hostspot wifi-sec.key-mgmt wpa-psk
nmcli con modify Hostspot wifi-sec.psk "veryveryhardpassword1234"
nmcli con up Hostspot

Also possible from nm-applet by creating a new connection, Setting it to
WiFi, changing the mode to Hotspot from Client, and setting the appropriate
SSID, Device, and Wi-Fi Security settings.

Diff Detail

Repository

R2155 network-manager

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

• Psi-Jack created this revision.Jun 30 2018, 4:26 PM

Herald added a reviewer: Triage Team. · View Herald TranscriptJun 30 2018, 4:26 PM

• Psi-Jack requested review of this revision.Jun 30 2018, 4:26 PM

• Psi-Jack added a child revision: D3192: Update to 1.8.14, bug fixes since 1.8.11-dev..Jun 30 2018, 5:08 PM

Note I'll switch out this patch with the upstream version (with the commit message etc). This is always preferable as it's easier to identify where it's from and that it's upstream. Also prefer .patch to .diff though I suppose it doesn't make much of a difference.

Also I think we decided that shifting the NM stack should happen with Gnome update (to ensure changes are implemented/fixed for Gnome/Budgie), so 1.10 is preferred atm.

This revision is now accepted and ready to land.Jul 2 2018, 12:56 AM

Closed by commit R2155:ce24e9052f43: NM dnsmasq isolation for wifi-ap (authored by • Psi-Jack, committed by • sunnyflunk). · Explain WhyJul 2 2018, 1:12 AM

This revision was automatically updated to reflect the committed changes.