Page MenuHomeSolus

Update simplenote to 1.1.6
ClosedPublic

Authored by Snuggle on Jun 21 2018, 8:26 PM.
Tags
None
Referenced Files
F10822889: D3133.id8640.diff
Sat, Jun 3, 12:14 AM
F10820659: D3133.id8350.diff
Fri, Jun 2, 5:06 AM
F10757559: D3133.id8497.diff
Wed, May 17, 9:43 AM
F10757550: D3133.id7790.diff
Wed, May 17, 9:36 AM
F10757521: D3133.id8640.diff
Wed, May 17, 9:24 AM
F10757516: D3133.id8350.diff
Wed, May 17, 9:21 AM
F10731014: D3133.diff
Thu, May 11, 2:25 AM
F10723940: D3133.id.diff
Sun, May 7, 10:14 AM

Details

Summary

Changelog - You can now sign in with a WordPress account + bug and security fixes.

Test Plan

Install package, make a note and ensure that I'm still able to edit text, add tags and that all basic functionality works.

image.png (851×1 px, 625 KB)

Diff Detail

Repository
R2907 simplenote
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Snuggle edited the test plan for this revision. (Show Details)EditedJun 21 2018, 8:29 PM

The newer version seems to ship a bunch of crud in /opt/. Did I make a mistake in my package.yml or should this be moved to a different directory?

Main reason for updating this application is because there's a really annoying "A newer version is available" notification whenever you open it.

Link to releases page - https://github.com/Automattic/simplenote-electron/releases

sunnyflunk added a subscriber: sunnyflunk.

I would suggest shifting /opt/Simplenote to /usr/share/simplenote, testing and confirming that it works (I do expect it to as they release a tarball build which is the same but without set directories).

However, you will likely need to patch the .desktop file to point to just simplenote, as I imagine it is pointing to /opt where it thinks it will be installed.

To confirm specifically after changing the directory:

  • simplenote in terminal loads simplenote
  • Can be launched from the menu entry
  • Simplenote continues to work correctly
package.yml
31

Can we make this a full link

ln -sv /usr/share/simplenote/simplenote $installdir/usr/bin/simplenote

This revision now requires changes to proceed.Jun 21 2018, 10:35 PM

Moved everything in /opt/Simplenote to /usr/share/simplenote and patched the .desktop file.

Snuggle marked an inline comment as done.EditedJun 22 2018, 5:53 PM

This should all be good now. ?

image.png (1×1 px, 1 MB)

JoshStrobl added a subscriber: JoshStrobl.
JoshStrobl added inline comments.
package.yml
21

Unnecessary documentation.

25

Unnecessary documentation.

28

Unnecessary documentation.

29–30

Unnecessary documentation.

pspec_x86_64.xml
22

There is still an opt folder. Should be nuked.

This revision now requires changes to proceed.Jul 11 2018, 8:54 PM

Update simplenote to 1.1.6

Update simplenote to 1.1.6

Removed documentation and directory-nuked /opt/simplenote. ?

DataDrake added inline comments.
package.yml
5–6

Should be -or-later

Done! Thanks for spotting. ?

This revision was not accepted when it landed; it landed in state Needs Review.Aug 5 2018, 2:58 PM
This revision was automatically updated to reflect the committed changes.