Page MenuHomeSolus

Update simplenote to 1.1.6
ClosedPublic

Authored by Snuggle on Jun 21 2018, 8:26 PM.

Details

Summary

Changelog - You can now sign in with a WordPress account + bug and security fixes.

Test Plan

Install package, make a note and ensure that I'm still able to edit text, add tags and that all basic functionality works.

Diff Detail

Repository
R2907 simplenote
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

Snuggle created this revision.Jun 21 2018, 8:26 PM
Snuggle requested review of this revision.Jun 21 2018, 8:26 PM
Snuggle edited the test plan for this revision. (Show Details)EditedJun 21 2018, 8:29 PM

The newer version seems to ship a bunch of crud in /opt/. Did I make a mistake in my package.yml or should this be moved to a different directory?

Main reason for updating this application is because there's a really annoying "A newer version is available" notification whenever you open it.

Link to releases page - https://github.com/Automattic/simplenote-electron/releases

sunnyflunk requested changes to this revision.Jun 21 2018, 10:35 PM
sunnyflunk added a subscriber: sunnyflunk.

I would suggest shifting /opt/Simplenote to /usr/share/simplenote, testing and confirming that it works (I do expect it to as they release a tarball build which is the same but without set directories).

However, you will likely need to patch the .desktop file to point to just simplenote, as I imagine it is pointing to /opt where it thinks it will be installed.

To confirm specifically after changing the directory:

  • simplenote in terminal loads simplenote
  • Can be launched from the menu entry
  • Simplenote continues to work correctly
package.yml
31

Can we make this a full link

ln -sv /usr/share/simplenote/simplenote $installdir/usr/bin/simplenote

This revision now requires changes to proceed.Jun 21 2018, 10:35 PM
Snuggle updated this revision to Diff 7800.Jun 22 2018, 5:51 PM

Moved everything in /opt/Simplenote to /usr/share/simplenote and patched the .desktop file.

Snuggle marked an inline comment as done.EditedJun 22 2018, 5:53 PM

This should all be good now. ?

JoshStrobl requested changes to this revision.Jul 11 2018, 8:54 PM
JoshStrobl added a subscriber: JoshStrobl.
JoshStrobl added inline comments.
package.yml
21

Unnecessary documentation.

25

Unnecessary documentation.

28

Unnecessary documentation.

29–30

Unnecessary documentation.

pspec_x86_64.xml
22–23

There is still an opt folder. Should be nuked.

This revision now requires changes to proceed.Jul 11 2018, 8:54 PM
Snuggle updated this revision to Diff 8349.Jul 23 2018, 3:52 AM

Update simplenote to 1.1.6

Snuggle updated this revision to Diff 8350.Jul 23 2018, 3:55 AM

Update simplenote to 1.1.6

Snuggle marked 5 inline comments as done.Jul 23 2018, 3:56 AM

Removed documentation and directory-nuked /opt/simplenote. ?

DataDrake added inline comments.
package.yml
6

Should be -or-later

Snuggle updated this revision to Diff 8497.Jul 30 2018, 6:31 AM
  • Fixed license issue!
Snuggle marked an inline comment as done.Jul 30 2018, 6:31 AM

Done! Thanks for spotting. ?

leinad added a subscriber: leinad.Jul 31 2018, 5:33 AM
kyrios123 accepted this revision.Aug 5 2018, 11:21 AM
kyrios123 added a subscriber: kyrios123.

LGTM, thanks

This revision was not accepted when it landed; it landed in state Needs Review.Aug 5 2018, 2:58 PM
This revision was automatically updated to reflect the committed changes.